Remove front end unit tests from code and README.md #371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrii-i
added
documentation
andrii-i
force-pushed
the
remove_js_unit_tests
branch
from
2f70694
to
040515a
Compare
JasonWeill
approved these changes
Aug 29, 2023
|
Thank you @JasonWeill |
|
Congrats on your first merged pull request in this project! 🎉 |
dlqqq
pushed a commit
to dlqqq/jupyter-ai
that referenced
this pull request
Sep 5, 2023
dlqqq
added a commit
that referenced
this pull request
Sep 5, 2023
* Update README, docs (#347) * Copy edits for brevity, adds large screenshot * Adds screenshot, adds principles to contributor docs * Uses screenshot class for home page image * Fix reference to screenshot * Copy edits * Update index.md Styles magic command * Copy edits based on @dlqqq's feedback * fix newline typo in improve_code (#364) * Remove frontend js unit tests as not planned (#371) * Added alias for bedrock titan model (#368) * Added alias for bedrock titan model * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> * relax pinning on importlib_metadata, typing_extensions (#363) == pinning is almost always to be avoided in packages, and tight pinning on backports like importlib_metadata is extremely unlikely to be desirable * Loads vector store index lazily (#374) * Upgrades LangChain to 0.0.277 * Pinned Pydantic version, updated pydantic references * add .yarn to .gitignore in 1.x for local dev --------- Co-authored-by: michaelchia <michael_chia7@msn.com> Co-authored-by: Andrii Ieroshenko <aieroshe@amazon.com> Co-authored-by: Piyush Jain <piyushjain@duck.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Min RK <benjaminrk@gmail.com>
dbelgrod
pushed a commit
to dbelgrod/jupyter-ai
that referenced
this pull request
Jun 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in #211, packages/jupyter-ai/README.md says "Frontend tests. This extension is using Jest for JavaScript code testing." but there are no meaningful Jest tests. We also don't plan to implement JS unit tests, plan to cover our needs with snapshot-based E2E testing.
This PR removes front end unit tests from code and README.md. This will remove confusion and create correct expectations. If need would arise, adding js unit tests back would be trivial.