Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests to CI pipeline #211

Closed
krassowski opened this issue Jun 4, 2023 · 0 comments · Fixed by #350
Closed

Add tests to CI pipeline #211

krassowski opened this issue Jun 4, 2023 · 0 comments · Fixed by #350
Assignees
Labels
enhancement New feature or request testing Quality assurance tests
Milestone

Comments

@krassowski
Copy link
Member

krassowski commented Jun 4, 2023

Problem

I would like to contribute. I hoped that some tests would run on CI for #210. I see that there is no linting as per:

The package appears to have three suites of tests documented in packages/jupyter-ai/README.md:

1. Python tests

(removed note about pip install -e .[tests] not working - it works if run from packages/jupyter-ai)

I see only one commented out test file.

2. Frontend tests

There are only two tests: one skipped and one useless.

3. Integration tests

There is only a smoke test.

Proposed Solution

If tests were written but not commited, commit them. If tests were not written either add a note for the contributors or plan writting them for newly added code? My issue is mostly about managing expectations, I do not think contributors should be expected to debug why tests (which are not there) do not run, and users should now that the package has no tests yet.

Additional context

Jupyter Criteria for official Subprojects include:

  • Use solid software engineering with documentation and tests hosted with appropriate technologies (Read The Docs and Travis are examples of technologies that can be used).
@krassowski krassowski added the enhancement New feature or request label Jun 4, 2023
@JasonWeill JasonWeill changed the title Tests. Where can I find tests? Add tests to CI pipeline Jun 5, 2023
@JasonWeill JasonWeill added the testing Quality assurance tests label Jun 6, 2023
@JasonWeill JasonWeill added this to the 0.11.0 Release milestone Jul 17, 2023
@andrii-i andrii-i mentioned this issue Aug 23, 2023
@JasonWeill JasonWeill linked a pull request Aug 28, 2023 that will close this issue
@JasonWeill JasonWeill removed a link to a pull request Aug 28, 2023
@JasonWeill JasonWeill linked a pull request Aug 28, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request testing Quality assurance tests
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants