Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restyle about dialog #6592

Merged
merged 5 commits into from
Oct 20, 2022
Merged

Restyle about dialog #6592

merged 5 commits into from
Oct 20, 2022

Conversation

kostyafarber
Copy link
Contributor

Description

The purpose of the pull request is to improve upon the style of the help dialog in Jupyter Notebook #6552

The updated dialog is as below.

Screen Shot 2022-10-18 at 17 19 53

@github-actions
Copy link
Contributor

Binder 👈 Launch a Binder on branch kostyafarber/notebook/issue-6552

@jtpio jtpio added this to the 7.0 milestone Oct 19, 2022
@jtpio
Copy link
Member

jtpio commented Oct 20, 2022

Thanks @kostyafarber this looks good.

I'm currently investigating the CI failure in #6579, will try to get it in before merging this PR.

Update variable contList to contributorList

Co-authored-by: Jeremy Tuloup <jeremy.tuloup@gmail.com>
@kostyafarber
Copy link
Contributor Author

kostyafarber commented Oct 20, 2022

@jtpio also I thought of perhaps making the links default to the orange highlight as in:

image

I think it would look better than the purple as it is now.

Also making the hover state over the url links the same grey as the dismiss button instead of the red, as in the current JuypterLite:

image

I couldn't figure out how to make those changes 😞 but they could round out the design and make it look better I think.

Just some thoughts!

@jtpio
Copy link
Member

jtpio commented Oct 20, 2022

I couldn't figure out how to make those changes disappointed but they could round out the design and make it look better I think.

It's probably in one of the CSS classes, we could investigate in a follow-up PR how to improve it yes.

@jtpio
Copy link
Member

jtpio commented Oct 20, 2022

Looks like the prettier failure is relevant (would need a lint pass): https://github.com/jupyter/notebook/actions/runs/3289225812/jobs/5420503955

Copy link
Member

@jtpio jtpio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jtpio jtpio merged commit 05ebf9d into jupyter:main Oct 20, 2022
@jtpio
Copy link
Member

jtpio commented Oct 20, 2022

@kostyafarber if you feel like iterating on this don't hesitate to open a new PR, thanks!

@kostyafarber
Copy link
Contributor Author

@jtpio thanks will do!

@kostyafarber
Copy link
Contributor Author

@jtpio Hey sorry to be that guy but would you be able to add the hacktoberfest-accepted label on this PR? Would be much appreciated 😄

@kostyafarber kostyafarber deleted the issue-6552 branch October 21, 2022 08:12
@jtpio jtpio added the hacktoberfest-accepted Temporary label for Hacktoberfest (could be deleted afterwards) label Oct 21, 2022
@jtpio
Copy link
Member

jtpio commented Oct 21, 2022

Sure thing, done!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement hacktoberfest-accepted Temporary label for Hacktoberfest (could be deleted afterwards)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants