Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to lerna 6 #6579

Merged
merged 6 commits into from
Oct 20, 2022
Merged

Update to lerna 6 #6579

merged 6 commits into from
Oct 20, 2022

Conversation

jtpio
Copy link
Member

@jtpio jtpio commented Oct 15, 2022

Update to the latest lerna version: https://github.com/lerna/lerna/releases/tag/v6.0.0

This new major version includes some task pipeline configuration by default now (via nx), which could be leveraged in this repo to speed up the build and enhance the developer experience: https://lerna.js.org/docs/concepts/task-pipeline-configuration

@jtpio jtpio added this to the 7.0 milestone Oct 15, 2022
@github-actions
Copy link
Contributor

Binder 👈 Launch a Binder on branch jtpio/notebook/update-lerna

@jtpio jtpio marked this pull request as draft October 16, 2022 07:29
@jtpio
Copy link
Member Author

jtpio commented Oct 19, 2022

Looks like some changes to the releaser actions lead to GITHUB_OUTPUT being create on disk:

$ node ./buildutils/lib/release-bump.js --force --skip-commit next
> git status
On branch main
Untracked files:
  (use "git add <file>..." to include in what will be committed)
	GITHUB_OUTPUT

image

@jtpio jtpio marked this pull request as ready for review October 20, 2022 10:55
@@ -1,5 +1,6 @@
{
"npmClient": "yarn",
"useNx": false,
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems required for now as it seems to be breaking the releaser check-npm step currently.

Will track that in a different issue.

@jtpio jtpio merged commit d5c9f54 into jupyter:main Oct 20, 2022
@jtpio jtpio deleted the update-lerna branch October 20, 2022 11:06
@jtpio jtpio mentioned this pull request Oct 20, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant