Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancements to the desktop entry #6099

Merged
merged 1 commit into from
Aug 2, 2021
Merged

Conversation

Amr-Ibra
Copy link
Contributor

- Add the argument %f to the Exec key so that a notebook file can be directly opened from the file manager by right-click → Open With Jupyter Notebook, or by double-clicking (https://specifications.freedesktop.org/desktop-entry-spec/latest/ar01s07.html)
- Add the Keyword key so that the Jupyter Notebook application can be searched with a keyword "python", e.g. from GNOME Shell (look for the Keywords key in the table https://specifications.freedesktop.org/desktop-entry-spec/latest/ar01s06.html)
- Add a semicolon ";" to the end of the strings in the Categories key (look at the examples here https://specifications.freedesktop.org/menu-spec/latest/ar01s03.html)
@kevin-bates
Copy link
Member

Hi @Amr-Ibra - thank you for the pull request. Since this desktop entry was added a few months ago via #6010 and I don't have any experience with it, I'd like to ask @befeleme to take a look at these changes to ensure they are ok.

@Amr-Ibra
Copy link
Contributor Author

A quick and easy way to test the changes is to place the jupyter-notebook.desktop file in ~/.local/share/applications:

  • Type python in the overview in GNOME Shell, and you'll see Jupyter Notebook in the results
  • Launch a notebook file by right-clicking on the file → Open with Jupyter Notebook

@befeleme
Copy link
Contributor

befeleme commented Aug 2, 2021

I've tested the proposed changes, all looks nice. Thumbs up for merging from me.

Copy link
Member

@kevin-bates kevin-bates left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (and based on feedback from those working with these feels).

@kevin-bates kevin-bates merged commit 903f2d3 into jupyter:master Aug 2, 2021
@Amr-Ibra Amr-Ibra deleted the patch-1 branch August 3, 2021 14:33
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants