Add square logo and desktop entry files #6010
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As was pointed out to me, environments displaying smaller icons (like Xfce) would benefit from icon without the text jupyter inside, so I add another file, favicon alike. |
|
@blink1073, just a quick question: when could the v. 6.3 be released? I'll help me adjust the next steps regarding the RPM package. |
|
We plan to cut 6.3 early next week. I'm making a changelog entry PR today. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
Following the ancient discussion in #1922 I work on adding a desktop entry to Notebook when installed as RPM in Fedora.
I was looking for the icon to use an thought the official Jupyter logo would suit the best. The image, being rectangle more than square, got however unpleasantly distorted by the system. The graphics was resized so that it's 48x48px square with preserved original proportions and is easily scalable to any other square size.
If the files were included in Python package, they could be used by the other packagers as well. It'd be nice to have them coming from the upstream.