Tooltip style scope fix #5672
Merged
Tooltip style scope fix #5672
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Change the scope of styles specific to `.dynamic-buttons` to that class only (introed in jupyter#4729) - Drop the width style from tooltips since `display: inline` makes it have no effect Fixes jupyter#5670
akx
approved these changes
Aug 12, 2020
There was a problem hiding this comment.
Looks good to me. Based on
~/b/jupyter-notebook (master) $ git grep visually-hidden
notebook/static/tree/less/tree.less:.visually-hidden {
~/b/jupyter-notebook (master) $ git grep button-and-tooltip
notebook/static/tree/less/tree.less:.button-and-tooltip {
the two dropped classes were indeed only used in this file, nowhere else.
Zsailer
approved these changes
Aug 12, 2020
|
@magdapoppins - This has been delivered in Notebook 6.1.2 which is now available - thank you for your contribution! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.dynamic-buttonsclass scopedFixes #5670