Tooltips visible through keyboard navigation for specified buttons: issue #3964 #4729
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tdown, Edit,Move, Delete buttons.
|
I don't pretend to be an expert, but I find it hard to believe we need all this. Tooltips have been a standard browser feature for ages, and the buttons have |
|
From the research we have done just using the title attribute does not work as a tooltip when using focus (as explained here: title attribute). We, therefore, had to implement it in a different way in order for this to work |
magdapoppins
added a commit
to magdapoppins/notebook
that referenced
this pull request
Aug 12, 2020
- Change the scope of styles specific to `.dynamic-buttons` to that class only (introed in jupyter#4729) - Drop the width style from tooltips since `display: inline` makes it have no effect Fixes jupyter#5670
magdapoppins
added a commit
to magdapoppins/notebook
that referenced
this pull request
Aug 12, 2020
- Change the scope of styles specific to `.dynamic-buttons` to that class only (introed in jupyter#4729) - Drop the width style from tooltips since `display: inline` makes it have no effect Fixes jupyter#5670
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed issue #3964. We have fixed the tooltips for the "Duplicate", "View", "Edit", "Delete" buttons, so that they are visible when navigated to using the keyboard.