This repository has been archived by the owner on Mar 9, 2022. It is now read-only.
Implement pprof support #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tests are failing because the fixes for #81 are needed here too. Once they've landed I'll rebase this PR and ensure the tests pass. |
amnonbc
approved these changes
May 29, 2018
amnonbc
reviewed
May 29, 2018
cmd/run.go
Outdated
| if c.PprofPort > 0 { | ||
| go func() { | ||
| log.Printf("starting pprof listener on port %d", c.PprofPort) | ||
| http.ListenAndServe(fmt.Sprintf(":%d", c.PprofPort), nil) |
There was a problem hiding this comment.
It might be worth printing out the error message returned by ListenAndServer. There may be another application already listening on PprofPort
There was a problem hiding this comment.
Good point. Doing that now.
Instead of having pprof support hardcoded into just the writer, allow the port to be specified via the configuration.
amnonbc
reviewed
Jun 4, 2018
| go func() { | ||
| log.Printf("starting pprof listener on port %d", c.PprofPort) | ||
| err := http.ListenAndServe(fmt.Sprintf(":%d", c.PprofPort), nil) | ||
| if err != nil { |
There was a problem hiding this comment.
http.ListenAndServe will only return if err is non-nil
So the if is unnecessary.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of having pprof support hardcoded into just the writer, allow the port to be specified via the configuration.