This repository has been archived by the owner on Mar 9, 2022. It is now read-only.
Fix HTTP listener benchmarks & bump perfcheck reference #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The interaction of the last two PRs resulted in the HTTP listener tests and benchmarks being broken. This change fixes that as well as suppressing log output during the HTTP listener benchmarks.
This means log output is now suppressed during the perfcheck reference benchmarks.
mjs
force-pushed
the
bump-perfcheck-reference
branch
from
8e9a712
to
22b95b7
Compare
This was referenced May 29, 2018
Merged
amnonbc
approved these changes
May 29, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The interaction of the last two PRs resulted in the HTTP listener benchmark logs being broken. This change fixes that as well as suppressing log output during these benchmarks.
The default reference revision used by perfcheck has been bumped so that log output is suppressed during the perfcheck reference benchmarks. This ensures that
benchcheckwill see all available benchmark output.