Fix for Critical Issue #2: Spawning 100% CPU Processes that Never Exit #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…h use 100% of a CPU core each and never terminate, even days later. Added options (which can change hard-coded or expose as user settings ideally) for reducing CPU priority Note: After pull, run npm install to install new dependencies added to package.json Git ignored package-lock.json Changed extension category to new "Programming Languages" instead of "Programming" to fix warning for that TODO: Expose settings under //Settings: section in search.js as extension settings to control timeout, CPU priority, etc. TODO: Requires further testing to ensure doesn't break spawning the node.exe for nak file search proccess and that always exits even if Ctrl-Click / Go to Definition for If or Var keywords in large projects with many node modules, for example.
…to change much further soon. Mentioned TypeScript in extension/package description as well.
Open
jrieken
requested changes
Jun 6, 2019
| @@ -1,9 +1,9 @@ | |||
| { | |||
| "name": "fuzzy-definitions", | |||
| "displayName": "Fuzzy Definitions", | |||
| "description": "Fuzzy 'Go to Definition' for JavaScript", | |||
| "description": "Fuzzy 'Go to Definition' for JavaScript and TypeScript", | |||
| @@ -19,7 +19,7 @@ | |||
| "vscode": "^1.0.0" | |||
| }, | |||
| "categories": [ | |||
| "Languages" | |||
| "Programming Languages" | |||
| @@ -3,7 +3,8 @@ | |||
| import * as vscode from 'vscode'; | |||
| import {extname, dirname, join} from 'path'; | |||
| import {exec} from 'child_process'; | |||
|
|
|||
| //import {which} from 'shelljs'; | |||
| let which = require('shelljs').which; | |||
| const nak = exec(cmd, (err, stdout, stderr) => { | ||
|
|
||
| // Settings: TODO: Expose below extension settings to users (possibly pattern for advanced users too?) | ||
|
|
There was a problem hiding this comment.
Better not - once we have microsoft/vscode#73524 this extension can re-use the VS Code search infrastructure.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for critical bug #2 "100% CPU" and related enhancements
Fixes & Enhancements
Notes
To-Do Suggestions