-
Notifications
You must be signed in to change notification settings - Fork 28.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stabilize FileSearchProvider API #73524
Comments
Yeah, it's about time... |
@jrieken @roblourens Can we revisit this -- so we can move forward with some kind of search provider functionality. I've been dying for this for a LONG time now and its blocking really cool use-cases in both GitLens and RemoteHub. |
And the TextSearchProvider API too please (#59921) 🙏 |
@jrieken eleven months ago you wrote:
Please can this get onto the April 2020 milestone? 🙏 📿 |
This is not my decision, search is owned by @roblourens, I own the API-process which ensures all API look and feels alike |
Please finalize this, this is really needed to fully implement extensions that use the FileSystemProvider, thanks! Do you need input? |
Any news about this? I'm creating an extension which isn't much worth without this functionality. I tested it and it works perfectly, but unfortunately I can't submit it to the marketplace... @roblourens |
This comment has been minimized.
This comment has been minimized.
@roblourens please can we blow the dust off this and get it into Stable? Or else get an understanding of what's holding it up? IMO as more and more FileSystemProvider implementations show up (aka virtual filesystems) the more important it becomes to resolve this. |
To echo @gjsjohnmurray, can this please be addressed? |
@roblourens does this also need to be reassigned to @andreamah in order to stand a chance of being finalized? |
Good point. I created #214175 to track that. Do you think you'd benefit from an alternative method of fuzzy matching and highlighting that is custom-defined? I would assume that something like what we have for |
Something specific to our file system is that for some folders, the actual name of the document is different than the |
I had a conversation with @TylerLeonhardt, who takes care of the quick picker and more UI-facing part of presenting search results, and it seems a little tricky to add logic for this. For a bit of context, the ranking/filtering/highlighting happens on the side of the picker. The reasons we'd be hesitant about supporting custom highlight/filtering logic are as follows:
I hope that sheds some clarity on why we'd likely just keep this the way it is. |
Profoundly grateful this is getting attention. I've had to create my own "quick pick" up until now, which is just not very user-friendly as it's a separate command (and thus probably key binding) from what they expect. I would utilize custom fuzzy matching if it was available, but can live without it. As they say, perfection is the enemy of done. |
Thanks for the explanation @andreamah, that all makes sense! I can definitely live without any custom fuzzy matching. |
Thanks for starting looking to it @andreamah! It would be great to have a proper cloud search integrated into our extension. |
Some news: in case you missed it, I'm finalizing this API with some other related APIs. You can see the status (plus a diagram) here. Since they're so intertwined, I felt that it made the most sense to me to address all the APIs as a group. |
@roblourens I created this issue in the hope
FileSearchProvider
is going to get finalized at some point. If yes, maybe add the api-finalization label here.If I'm out of order creating this, or if I've overlooked another issue dealing with its finalization, please close.
The text was updated successfully, but these errors were encountered: