Improve requiring claims #456
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I moved the testing requirements into tox.ini for the variant testing. I added ecdsa, pycryptodome, and tox to the dev extras so that you can run the tests outside of tox as well.
Note that pycrypto does not work with python 3.8 since they removed `time.clock` altogether. pycrypto/pycrypto#283
dave-shawley
force-pushed
the
improve-require-claim
branch
from
85bc048
to
fd8bbd6
Compare
|
Looks like #280 was merged 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for implementing and maintaining this library! This PR changes the processing of required claims so that arbitrary claims may be required by name. I needed to require that the issuer claim was present without requiring a specific value. There wasn't a easy way to do this, so I figured that I would add one.
I converted the required claim processing to look at any option starting with
require_and require that a claim named by the suffix is present in the payload. Hopefully that explanation makes some sense. If not, the code is pretty simple.I also took a stab at fixing the testing against Pycryptodome. I can remove the test related commits if necessary.