-
-
Notifications
You must be signed in to change notification settings - Fork 676
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Require tweak #280
Require tweak #280
Conversation
679938c
to
4fa58b2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, I think we can do this.
@mark-adams thoughts?
4fa58b2
to
5f7be20
Compare
Don't know why it's failing, hopefully I didn't mess the rebase. |
5f7be20
to
b894d78
Compare
Just in case it was missed, I've rebased it again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple minor changes
b894d78
to
64ae4d8
Compare
@mark-adams It's been quite a while since the last changes, is something else needed to accept these changes? This functionality would still simplify my code :) |
Bump. I would also like to see this functionality released. |
64ae4d8
to
2130d36
Compare
Rebased patchset to master. Is there anything missing? |
Deprecate the use of the boolean options
c690925
to
1e6f1a3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
thanks for your patience! |
* Use require options as a list, instead of booleans Deprecate the use of the boolean options * Add test for the new require option * Add documentation on how to use the require option Co-authored-by: Pau Ruiz i Safont <psafont@ebi.ac.uk>
Goes ahead with the proposal in #279
Added a test and documentation on how to use the new parameter.
I took the liberty to deprecate the 'verify_xxx' options while still allowing them (as evidenced by the existing tests)
Feel free to critique any of the changes.