Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consistent "name" value in language manifest #26098 #759

Merged
merged 1 commit into from
Sep 1, 2019

Conversation

zero-24
Copy link
Member

@zero-24 zero-24 commented Aug 31, 2019

Pull Request für Issue joomla/joomla-cms#26098

Zusammenfassung der Änderungen

Laut den neun Regel soll das Attribut "name" an beiden stellen gleich lauten. Siehe: joomla/joomla-cms#26098

Ich warte noch auf eine finale Bestätigung durch die TT Coordinatoren.

@zero-24 zero-24 requested a review from a team August 31, 2019 16:42
@tecpromotion tecpromotion self-assigned this Sep 1, 2019
@tecpromotion tecpromotion changed the title [WIP] Consistent "name" value in language manifest #26098 Consistent "name" value in language manifest #26098 Sep 1, 2019
@tecpromotion tecpromotion added this to the 3.9.12v1 milestone Sep 1, 2019
@tecpromotion tecpromotion merged commit e1d12e1 into joomlagerman:master Sep 1, 2019
@zero-24 zero-24 deleted the consistent_name branch September 1, 2019 19:33
@tecpromotion
Copy link
Member

@zero-24 ist das nicht relevant?

<name>German (DE)</name>

@zero-24
Copy link
Member Author

zero-24 commented Sep 1, 2019

Keine Ahnung ist im Core auch so: https://github.com/joomla/joomla-cms/blob/staging/administrator/language/en-GB/install.xml#L3

ggf kann @Bakual hier helfen und sagen was richtig / falsch ist?

@Bakual
Copy link

Bakual commented Sep 2, 2019

Ich frag mal bei der grauen Eminenz nach :)

@tecpromotion
Copy link
Member

Ich frag mal bei der grauen Eminenz nach :)

Wobei im englischen auch der name tag außerhalb des metadata ja immer English (en-GB) ist. Bei uns aber schon lange German (Germany).
Wahrscheinlich bleibt der name so.
Frage ob wir das anpassen auf German (de-DE) etc. oder so lassen wollen.

@Bakual
Copy link

Bakual commented Sep 2, 2019

Die grauen Eminenzen meinen man kann es bei der Installation lassen wie es ist. Es wird nicht wirklich irgendwo angezeigt.

@tecpromotion
Copy link
Member

Danke

chmst added a commit to chmst/joomla that referenced this pull request Dec 11, 2019
zero-24 added a commit that referenced this pull request Mar 31, 2020
* see PR #759

* joomla.ini

* Update language/de-DE/joomla.ini

Co-Authored-By: Stefan Wendhausen <stefan.wendhausen@tec-promotion.de>

* Update language/de-DE/install.xml

Co-Authored-By: Stefan Wendhausen <stefan.wendhausen@tec-promotion.de>

* Update language/de-DE/joomla.ini

Co-Authored-By: Stefan Wendhausen <stefan.wendhausen@tec-promotion.de>

* Update language/de-DE/joomla.ini

Co-Authored-By: Stefan Wendhausen <stefan.wendhausen@tec-promotion.de>

* Update language/de-DE/joomla.ini

Co-Authored-By: Stefan Wendhausen <stefan.wendhausen@tec-promotion.de>

* Update de-DE.lib_phpass.sys.ini

* Update install.xml

* Update joomla.ini

* Update de-DE.files_joomla.sys.ini

* Update de-DE.lib_phpass.sys.ini

* Update joomla.ini

* Update joomla.ini

* Update joomla.ini

* Rename de-DE.finder_cli.ini to finder_cli.ini

* Rename de-DE.lib_phpass.sys.ini to lib_phpass.sys.ini

* Rename de-DE.lib_joomla.ini to lib_joomla.ini

* Delete lib_phpass.sys.ini

* Update joomla.ini

* Update lib_joomla.ini

* Update lib_joomla.ini

* Update language/de-DE/lib_joomla.ini

Co-Authored-By: Tobias Zulauf <zero-24@users.noreply.github.com>

* Update language/de-DE/lib_joomla.ini

Co-Authored-By: Tobias Zulauf <zero-24@users.noreply.github.com>

* Update language/de-DE/lib_joomla.ini

Co-Authored-By: Tobias Zulauf <zero-24@users.noreply.github.com>

* Update language/de-DE/lib_joomla.ini

Co-Authored-By: Tobias Zulauf <zero-24@users.noreply.github.com>

* Update language/de-DE/lib_joomla.ini

Co-Authored-By: Tobias Zulauf <zero-24@users.noreply.github.com>

* Update language/de-DE/joomla.ini

Co-Authored-By: Tobias Zulauf <zero-24@users.noreply.github.com>

* Update language/de-DE/lib_joomla.ini

Co-Authored-By: Tobias Zulauf <zero-24@users.noreply.github.com>

* Update language/de-DE/lib_joomla.ini

Co-Authored-By: Tobias Zulauf <zero-24@users.noreply.github.com>

* Update language/de-DE/lib_joomla.ini

Co-Authored-By: Tobias Zulauf <zero-24@users.noreply.github.com>

* Update language/de-DE/lib_joomla.ini

Co-Authored-By: Tobias Zulauf <zero-24@users.noreply.github.com>

* Update language/de-DE/lib_joomla.ini

Co-Authored-By: Tobias Zulauf <zero-24@users.noreply.github.com>

* Update language/de-DE/lib_joomla.ini

* Update language/de-DE/lib_joomla.ini

Co-Authored-By: Tobias Zulauf <zero-24@users.noreply.github.com>

* Update language/de-DE/lib_joomla.ini

* Update language/de-DE/lib_joomla.ini

* Update language/de-DE/lib_joomla.ini

* Update language/de-DE/lib_joomla.ini

Co-authored-by: chmst <dev@chmst.de>
Co-authored-by: Tobias Zulauf <zero-24@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants