Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consistent "name" value in language manifest #26098

Merged
merged 3 commits into from
Aug 31, 2019

Conversation

Bakual
Copy link
Contributor

@Bakual Bakual commented Aug 31, 2019

The translators were asked to make the "name" tag in the language manifest files consistent with the "nativeName" one. The latter being a translation of the former (english) one.

Summary of Changes

Changes <name> tag in en-GB.xml files to "English (United Kingdom)"

Testing Instructions

Review should be enough.

@joomla-cms-bot joomla-cms-bot added Language Change This is for Translators PR-staging labels Aug 31, 2019
@infograf768
Copy link
Member

I would have simply used (UK) instead of repeating (United kingdom)

@infograf768
Copy link
Member

Forget my suggestion

@infograf768
Copy link
Member

Travis tests fail

@infograf768 infograf768 merged commit caa62ee into joomla:staging Aug 31, 2019
@infograf768
Copy link
Member

Merged. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants