Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.0] Remove IE 11 warning message due to EOL #2639

Closed
jgerman-bot opened this issue Oct 23, 2022 · 0 comments · Fixed by #2651
Closed

[5.0] Remove IE 11 warning message due to EOL #2639

jgerman-bot opened this issue Oct 23, 2022 · 0 comments · Fixed by #2651

Comments

@jgerman-bot
Copy link

New language relevant PR in upstream repo: joomla/joomla-cms#39018 Here are the upstream changes:

Click to expand the diff!
diff --git a/administrator/language/en-GB/joomla.ini b/administrator/language/en-GB/joomla.ini
index 1afcbb710aff..4c10fdd2ac3a 100644
--- a/administrator/language/en-GB/joomla.ini
+++ b/administrator/language/en-GB/joomla.ini
@@ -692,6 +692,7 @@ JGLOBAL_VOTES="Votes"
 JGLOBAL_VOTES_ASC="Votes ascending"
 JGLOBAL_VOTES_DESC="Votes descending"
 JGLOBAL_WARNCOOKIES="Warning! Cookies must be enabled to access the Administrator Backend."
+; @deprecated 5.0 will be removed in 6.0
 JGLOBAL_WARNIE="Warning! Internet Explorer should not be used for proper operation of the Administrator Backend."
 JGLOBAL_WARNJAVASCRIPT="Warning! JavaScript must be enabled for proper operation of the Administrator Backend."
 JGLOBAL_WIDTH="Width"
diff --git a/administrator/templates/atum/login.php b/administrator/templates/atum/login.php
index 3f043caabfc2..ded2802b62fa 100644
--- a/administrator/templates/atum/login.php
+++ b/administrator/templates/atum/login.php
@@ -102,9 +102,6 @@
             <?php echo Text::_('JGLOBAL_WARNJAVASCRIPT'); ?>
         </div>
     </noscript>
-    <div class="ie11 alert alert-warning" role="alert">
-        <?php echo Text::_('JGLOBAL_WARNIE'); ?>
-    </div>
 
     <header id="header" class="header d-flex">
         <div class="header-title d-flex">
diff --git a/api/language/en-GB/joomla.ini b/api/language/en-GB/joomla.ini
index 28099f5f552d..3301b8cff094 100644
--- a/api/language/en-GB/joomla.ini
+++ b/api/language/en-GB/joomla.ini
@@ -685,6 +685,7 @@ JGLOBAL_VOTES="Votes"
 JGLOBAL_VOTES_ASC="Votes ascending"
 JGLOBAL_VOTES_DESC="Votes descending"
 JGLOBAL_WARNCOOKIES="Warning! Cookies must be enabled to access the Administrator Backend."
+; @deprecated 5.0 will be removed in 6.0
 JGLOBAL_WARNIE="Warning! Internet Explorer should not be used for proper operation of the Administrator Backend."
 JGLOBAL_WARNJAVASCRIPT="Warning! JavaScript must be enabled for proper operation of the Administrator Backend."
 JGLOBAL_WIDTH="Width"
diff --git a/build/media_source/templates/administrator/atum/scss/blocks/_login.scss b/build/media_source/templates/administrator/atum/scss/blocks/_login.scss
index dd28e05015eb..2b7238927594 100644
--- a/build/media_source/templates/administrator/atum/scss/blocks/_login.scss
+++ b/build/media_source/templates/administrator/atum/scss/blocks/_login.scss
@@ -256,18 +256,6 @@ label {
   }
 }
 
-// Detect IE 10+ and display alert
-.ie11 {
-  display: none;
-}
-
-@media all and (-ms-high-contrast: none),
-  (-ms-high-contrast: active) {
-  .ie11 {
-    display: block;
-  }
-}
-
 .login_message {
   margin: 1rem 1rem 0;
 }
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging a pull request may close this issue.

4 participants