-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[5.0] Remove IE 11 warning message due to EOL #39018
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did a codereview and looks good.
Well even when IE11 is EOL its still used in the wild not sure whether it makes much sense to remove it now. J5 a few months from now would be where i would remove such a message as that is a major with possible also more changes on the backend template site etc. |
+100 Nothing has changed in our code to justify removing the error message. Joomla admin still will not work with internet explorer but with this PR no one will know that the browser is the cause of the problems and will now think Joomla is broken. Internet Explorer is still in use even if it is eol and a user should be told when they get an error. Just because in the wealthy western web the usage of IE has dropped below 1% does not mean that it is true globally. For example in Iran, where joomla is heavily used due to our almost unique, support for the jihali calendar ie usage is still over 8% https://gs.statcounter.com/browser-market-share/desktop/iran There are many other countries where Joomla is actively used where the % is 5% or over. |
As this has now been rebased to 5.0 please re-open and merge #37900 |
Thanks |
Thank you |
See #37900 .
Summary of Changes
This PR removed the "Warning! Internet Explorer should not be used for proper operation of the Administrator Backend." message completely from the backend.
Testing Instructions
Code review or check the backend login with brocken CSS
Actual result BEFORE applying this Pull Request
Message is displayed (also if CSS is broken)
Expected result AFTER applying this Pull Request
No message ever
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org: Add information about removal of the .ie11 class Manual#51
No documentation changes for manual.joomla.org needed