Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.0] Remove IE 11 warning message due to EOL #39018

Merged
merged 4 commits into from
Oct 22, 2022

Conversation

bembelimen
Copy link
Contributor

@bembelimen bembelimen commented Oct 22, 2022

See #37900 .

Summary of Changes

This PR removed the "Warning! Internet Explorer should not be used for proper operation of the Administrator Backend." message completely from the backend.

Testing Instructions

Code review or check the backend login with brocken CSS

Actual result BEFORE applying this Pull Request

Message is displayed (also if CSS is broken)

Expected result AFTER applying this Pull Request

No message ever

Link to documentations

Please select:

@joomla-cms-bot joomla-cms-bot added Language Change This is for Translators NPM Resource Changed This Pull Request can't be tested by Patchtester PR-4.3-dev labels Oct 22, 2022
Copy link
Member

@Hackwar Hackwar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did a codereview and looks good.

@laoneo laoneo added the Maintainers Checked Used if the PR is conceptional useful label Oct 22, 2022
@zero-24
Copy link
Contributor

zero-24 commented Oct 22, 2022

Well even when IE11 is EOL its still used in the wild not sure whether it makes much sense to remove it now. J5 a few months from now would be where i would remove such a message as that is a major with possible also more changes on the backend template site etc.

@brianteeman
Copy link
Contributor

Well even when IE11 is EOL its still used in the wild not sure whether it makes much sense to remove it now. J5 a few months from now would be where i would remove such a message as that is a major with possible also more changes on the backend template site etc.

+100

Nothing has changed in our code to justify removing the error message. Joomla admin still will not work with internet explorer but with this PR no one will know that the browser is the cause of the problems and will now think Joomla is broken.

Internet Explorer is still in use even if it is eol and a user should be told when they get an error.

Just because in the wealthy western web the usage of IE has dropped below 1% does not mean that it is true globally.

For example in Iran, where joomla is heavily used due to our almost unique, support for the jihali calendar ie usage is still over 8% https://gs.statcounter.com/browser-market-share/desktop/iran

There are many other countries where Joomla is actively used where the % is 5% or over.

@Hackwar Hackwar changed the base branch from 4.3-dev to 5.0-dev October 22, 2022 10:01
@Hackwar Hackwar requested a review from rdeutz as a code owner October 22, 2022 10:01
@Hackwar Hackwar changed the base branch from 5.0-dev to 4.3-dev October 22, 2022 10:01
@bembelimen bembelimen changed the base branch from 4.3-dev to 5.0-dev October 22, 2022 13:47
@bembelimen bembelimen changed the title [4.3] Remove IE 11 warning message due to EOL [5.0] Remove IE 11 warning message due to EOL Oct 22, 2022
@brianteeman
Copy link
Contributor

As this has now been rebased to 5.0 please re-open and merge #37900

@HLeithner HLeithner merged commit 1d31c31 into joomla:5.0-dev Oct 22, 2022
@HLeithner
Copy link
Member

Thanks

@brianteeman
Copy link
Contributor

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Language Change This is for Translators Maintainers Checked Used if the PR is conceptional useful NPM Resource Changed This Pull Request can't be tested by Patchtester PR-5.0-dev
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants