Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.4] [bug] Media manager misbehaves on files with capitalized extensions #43336

Merged
merged 3 commits into from
Apr 26, 2024

Conversation

dgrammatiko
Copy link
Contributor

Pull Request for Issue #43315 .

Summary of Changes

  • Fix the logic

Testing Instructions

Note that you have to copy the file, Media Manager always normalizes extensions to lowercase!!!

  • Copy a file with a capitalized extension
  • Try to edit -> rotate -> save

Actual result BEFORE applying this Pull Request

File is not saved

Expected result AFTER applying this Pull Request

File is saved

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@Quy
Copy link
Contributor

Quy commented Apr 23, 2024

Missing this change:

$tmpFile = Path::clean(\dirname($localPath) . '/' . uniqid() . '.' . strtolower(File::getExt($name)));

Then the other PR can be closed as this will be upmerged. Thanks.

@HLeithner HLeithner added the bug label Apr 24, 2024
@HLeithner HLeithner changed the title [4.4][bug] Media manager misbehaves on files with capitalized extensions [4.4] [bug] Media manager misbehaves on files with capitalized extensions Apr 24, 2024
@Quy
Copy link
Contributor

Quy commented Apr 26, 2024

I have tested this item ✅ successfully on 2e448dc


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43336.

1 similar comment
@alikon
Copy link
Contributor

alikon commented Apr 26, 2024

I have tested this item ✅ successfully on 2e448dc


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43336.

@alikon
Copy link
Contributor

alikon commented Apr 26, 2024

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43336.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Apr 26, 2024
@MacJoom MacJoom self-assigned this Apr 26, 2024
@MacJoom MacJoom added this to the Joomla! 4.4.5 milestone Apr 26, 2024
@MacJoom MacJoom merged commit bd6ca75 into joomla:4.4-dev Apr 26, 2024
4 checks passed
@MacJoom
Copy link
Contributor

MacJoom commented Apr 26, 2024

Thank you!

@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Apr 26, 2024
@dgrammatiko dgrammatiko deleted the 4.4-dev-mm-bug branch April 26, 2024 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NPM Resource Changed This Pull Request can't be tested by Patchtester PR-4.4-dev
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants