[5.1][bug] Media manager misbehaves on files with capitalized extensions

[dgrammatiko]

Pull Request for Issue #43315 .

Summary of Changes

• Fix the logic

Testing Instructions

Note that you have to copy the file, Media Manager always normalizes extensions to lowercase!!!

• Copy a file with a capitalized extension
• Try to edit -> rotate -> save

Actual result BEFORE applying this Pull Request

File is not saved

Expected result AFTER applying this Pull Request

File is saved

Link to documentations

Please select:

• Documentation link for docs.joomla.org:

• No documentation changes for docs.joomla.org needed

• Pull Request link for manual.joomla.org:

• No documentation changes for manual.joomla.org needed

[brianteeman]

tested crop, resize and rotate successfully with an image named potato.JPG

[brianteeman]

I have tested this item ✅ successfully on e42d7e7

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43325.}

[dautrich]

Tested resize and rotate unsuccessfully with a file named DSC_0008.JPG
Buttons "Save" and "Save & Close" seemed to work, but afterward the image was unchanged.

[dautrich]

I have tested this item 🔴 unsuccessfully on e42d7e7

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43325.}

[dgrammatiko]

@dautrich how did you test this PR? Did you d/l the prebuild installation or just applied the patch with the non working for this case patch tester?

[Quy]

Please apply to crop.

[dautrich]

@dgrammatiko
I tested with patchtester, but I can repeat my test with the prebuilt package.

Just for my understanding: Why does testing this PR with patchtester not work? And how can I recognize such a test? Is there a special flag?

[dautrich]

I have tested this item ✅ successfully on 1c79063

I tested with the prebuilt package (now). Took the same picture as before. Cropped, saved, resized, saved, rotated, saved and closed. Saw modified picture in media manager.

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43325.}

[dgrammatiko]

@dautrich iirc patchtester cannot be used on any PRs that have the label NPM Resource Changed and Coposer Dependency Changed. Thanks for testing

[viocassel]

I have tested this item ✅ successfully on 1c79063

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43325.}

[alikon]

RTC

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43325.}

[dgrammatiko]

@laoneo @LadySolveig do you want this against 5.x or 4.4.x? The issue exists in both branches and files seems to be identical (although the reported issue was for 5.x)...

[exlemor]

Hi @dgrammatiko, I had initially created #43220 which is similar / partially around the same topic and I was recommended to base it for 4.4.x (and I confirmed the issues are both in 4.4.x and 5.x) since it would be 'up-patched' (or whatever the technical term).

[laoneo]

If you do it against 4.4, then it must be retested and this one closed. For me it is ok to leave it in 5 but when you feel in the mood to backport to 4, then this one should be closed as it will be upmerged anyway.

[dgrammatiko]

I'll open a new one for 4.4, let me know if this should be closed or could be merged (skipping the upmerge)

[dgrammatiko]

PR for 4.4.x: #43336

[HLeithner]

closing since we have a pr for 4.4