Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.2] replace scss variables by css variables #42509

Conversation

hans2103
Copy link
Contributor

Pull Request for Issue #41105 .

Summary of Changes

This PR will replace the SCSS variables used to adjust the styling of btn-secondary by css variables.
With this change we are more in line with the rest of the css using css variables

Testing Instructions

Before and after the test the look and feel of an element with className btn-secondary should be the same

  • Have a Joomla website up and running
  • Apply this PR
  • Rebuild the assets using npm run watch (or similar)
  • Refresh the page
  • Inspect the css inside Dev Toolbar

Actual result BEFORE applying this Pull Request

Scherm­afbeelding 2023-12-13 om 16 27 45

Expected result AFTER applying this Pull Request

Scherm­afbeelding 2023-12-13 om 16 28 22

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@joomla-cms-bot joomla-cms-bot added NPM Resource Changed This Pull Request can't be tested by Patchtester PR-5.1-dev labels Dec 13, 2023
@hans2103 hans2103 changed the title replace scss variables by css variables [5.1] replace scss variables by css variables Dec 13, 2023
@richard67
Copy link
Member

@hans2103 When you make a pull request for your own issue then please close the issue.

@hans2103
Copy link
Contributor Author

quest for your own issue then please close th

my bad... thank you

@fgsw
Copy link

fgsw commented Dec 16, 2023

The Download is not available (Expected — Waiting for status to be reported).

@brianteeman
Copy link
Contributor

Not expected - it should not take 2 days ;)

@alikon
Copy link
Contributor

alikon commented Dec 16, 2023

Prebuilt Download Packages are available here https://artifacts.joomla.org/drone/joomla/joomla-cms/5.1-dev/42509/downloads/72262

@Quy
Copy link
Contributor

Quy commented Mar 8, 2024

I have tested this item ✅ successfully on 9d24a00


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42509.

1 similar comment
@viocassel
Copy link
Contributor

I have tested this item ✅ successfully on 9d24a00


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42509.

@richard67
Copy link
Member

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42509.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Mar 8, 2024
@HLeithner HLeithner changed the base branch from 5.1-dev to 5.2-dev April 24, 2024 09:07
@HLeithner
Copy link
Member

This pull request has been automatically rebased to 5.2-dev.

@HLeithner HLeithner changed the title [5.1] replace scss variables by css variables [5.2] replace scss variables by css variables Apr 24, 2024
@Quy Quy removed the PR-5.1-dev label Apr 25, 2024
@pe7er pe7er self-assigned this Apr 30, 2024
@pe7er pe7er enabled auto-merge (squash) April 30, 2024 08:00
@pe7er pe7er merged commit d8ba91c into joomla:5.2-dev Apr 30, 2024
3 checks passed
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Apr 30, 2024
@Quy Quy added this to the Joomla! 5.2.0 milestone Apr 30, 2024
@pe7er
Copy link
Contributor

pe7er commented Apr 30, 2024

Thanks @hans2103 !

@hans2103 hans2103 deleted the feature/41105=hard-coded-colors-instead-of-css-variables branch April 30, 2024 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature NPM Resource Changed This Pull Request can't be tested by Patchtester PR-5.2-dev
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet