-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[5.2] replace scss variables by css variables #42509
[5.2] replace scss variables by css variables #42509
Conversation
@hans2103 When you make a pull request for your own issue then please close the issue. |
my bad... thank you |
The Download is not available ( |
Not expected - it should not take 2 days ;) |
Prebuilt Download Packages are available here https://artifacts.joomla.org/drone/joomla/joomla-cms/5.1-dev/42509/downloads/72262 |
I have tested this item ✅ successfully on 9d24a00 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42509. |
1 similar comment
I have tested this item ✅ successfully on 9d24a00 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42509. |
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42509. |
This pull request has been automatically rebased to 5.2-dev. |
Thanks @hans2103 ! |
Pull Request for Issue #41105 .
Summary of Changes
This PR will replace the SCSS variables used to adjust the styling of btn-secondary by css variables.
With this change we are more in line with the rest of the css using css variables
Testing Instructions
Before and after the test the look and feel of an element with className
btn-secondary
should be the samenpm run watch
(or similar)Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed