Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hard coded colors instead of css variables #41105

Closed
hans2103 opened this issue Jul 3, 2023 · 3 comments
Closed

Hard coded colors instead of css variables #41105

hans2103 opened this issue Jul 3, 2023 · 3 comments

Comments

@hans2103
Copy link
Contributor

hans2103 commented Jul 3, 2023

Media/templates/site/cassiopeia/scss/vendor/bootstrap/_buttons.scss

what is the use of hard coded colors when we work with css variables instead?

color: $gray-800;
background-color: $white;
border-color: $gray-400;
&:hover,
&:focus {
color: $gray-800;
background-color: $gray-100;
}
}
.article-info .association,
.cat-list-association {
.btn-secondary {
font-weight: 700;
color: $white;
background-color: $gray-600;
border-color: $gray-400;
&:hover,
&:focus {
color: $white;
background-color: $gray-800;

@brianteeman
Copy link
Contributor

are you referring to using $white instead of var(--something) ??

@hans2103
Copy link
Contributor Author

hans2103 commented Jul 3, 2023

See screenshot below where .btn-secondary has both css variables as scss variables.
Scherm­afbeelding 2023-07-03 om 10 42 11

@richard67
Copy link
Member

Closing as having a pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants