Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.3] The "Forbidden MIME Types" parameter is not used #39196

Closed
wants to merge 10 commits into from
Closed

[4.3] The "Forbidden MIME Types" parameter is not used #39196

wants to merge 10 commits into from

Conversation

Kostelano
Copy link
Contributor

Pull Request for Issue # .

Summary of Changes

In the settings of the Media component at the very bottom there is a parameter Forbidden MIME Types, which is not used and it is not known if it was ever used. More from Joomla 3x.

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@joomla-cms-bot joomla-cms-bot added Language Change This is for Translators PR-4.3-dev labels Nov 11, 2022
@richard67
Copy link
Member

It is even not used when the MIME type check is switched on?

@Kostelano
Copy link
Contributor Author

It is even not used when the MIME type check is switched on?

@Quy mentioned issue. It just says that the dependency is removed in 3.7.1. At the moment there is no connection with the parameter.

@ReLater
Copy link
Contributor

ReLater commented Nov 11, 2022

It is even not used when the MIME type check is switched on?

As reference: #38280

@richard67
Copy link
Member

@ReLater Thanks.

@richard67
Copy link
Member

@Kostelano Can it be that by accident you merged the 4.0-dev branch into the branch for this PR (which is based on 4.3-dev)? The PR shows 56 changed files now on GitHub- Possibly that might be fixed with the next update of the 4.3-dev branch to the 4.2-dev branch. Just wanted to tell so you know the reason.

@Kostelano
Copy link
Contributor Author

Kostelano commented Nov 16, 2022

Oh, thanks @richard67, I didn't notice. But it seems that I updated the branch as usual, with the 1st button.

UPD
Also, somehow RANDOMLY requested @laoneo. Sorry, by accident.

Kostelano and others added 8 commits November 16, 2022 22:28
There is a z-index issue with the media manager when you enable the infobar.

To test you will need to have quite a lot of images in the folder. I just copied all the cassiopeia sample images a few times.

## Before
When scrolling in image mode the sticky toolbar is cropped partially - see video
When scrolling in list mode the sticky toolbar is cropped a bit more - see video

## After
The entire toolbar is sticky and visible see video
* Check if field is subform and correct field name

* Slightly less forced; only will force the fieldname if it has been hardcoded as 'row'.

* Update components/com_users/tmpl/profile/default_custom.php

* Moving if block up

Plus unsetting the temp variable to free up memory.

* wrapping single lines with php as requested

though I disagree strongly with the requested change.
The key used here does not have a value in any of the language files.

On closer inspection it should simply be using an existing key which is used in identical uses for plugins

Code review should be fine
@joomla-cms-bot joomla-cms-bot added the NPM Resource Changed This Pull Request can't be tested by Patchtester label Nov 24, 2022
@Kostelano Kostelano closed this Dec 18, 2022
@Kostelano Kostelano deleted the 4-3-upload-mime-illegal branch December 18, 2022 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Language Change This is for Translators NPM Resource Changed This Pull Request can't be tested by Patchtester
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants