Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.2] Fix Calendar pointer #39227

Merged
merged 2 commits into from
Nov 23, 2022
Merged

Conversation

brianteeman
Copy link
Contributor

Summary of Changes

The calendar widget used for setting the publishing date etc is sometimes using the wrong cursor when it should be using a pointer. Otherwise its not clear that the item is indeed clickable

Testing Instructions

image

Actual result BEFORE applying this Pull Request

Moving the cursor over any of the top 4 highlighted areas above and the cursor will be an i-beam text cursor
Moving the cursor over any of the bottom 2 highlighted areas above and the cursor will be an arrow cursor

Expected result AFTER applying this Pull Request

moving the cursor over any of the 6 highlighted areas above and the cursor will be the pointing finger cursor as expected

Any other comments about any other css in the calendar is off-topic and will be ignored.

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@joomla-cms-bot joomla-cms-bot added NPM Resource Changed This Pull Request can't be tested by Patchtester PR-4.2-dev labels Nov 16, 2022
@Quy
Copy link
Contributor

Quy commented Nov 17, 2022

I have tested this item ✅ successfully on baf67cb


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39227.

1 similar comment
@viocassel
Copy link
Contributor

I have tested this item ✅ successfully on baf67cb


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39227.

@joomla-cms-bot joomla-cms-bot removed NPM Resource Changed This Pull Request can't be tested by Patchtester PR-4.2-dev labels Nov 18, 2022
@alikon
Copy link
Contributor

alikon commented Nov 18, 2022

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39227.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Nov 18, 2022
@richard67 richard67 added NPM Resource Changed This Pull Request can't be tested by Patchtester PR-4.2-dev labels Nov 18, 2022
@laoneo laoneo merged commit b53b47c into joomla:4.2-dev Nov 23, 2022
@laoneo
Copy link
Member

laoneo commented Nov 23, 2022

Thanks!

@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Nov 23, 2022
@laoneo laoneo added this to the Joomla! 4.2.6 milestone Nov 23, 2022
@brianteeman
Copy link
Contributor Author

thank you

@brianteeman brianteeman deleted the calendar_pointer branch November 23, 2022 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NPM Resource Changed This Pull Request can't be tested by Patchtester
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants