Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix display of data-function #38959

Merged
merged 9 commits into from
Feb 22, 2023
Merged

Conversation

chmst
Copy link
Contributor

@chmst chmst commented Oct 14, 2022

Pull Request for Issue #38958

Open: removing modal from com_sheduler.

Summary of Changes

Fix display of data-function in com_modules, remove data-function in com_scheduler
Remove modal view

Testing Instructions

Compare the html code of Select screens of com_modules and com_scheduler
Try to find a situation where a modal view is missing.

Actual result BEFORE applying this Pull Request

grafik

Expected result AFTER applying this Pull Request

No data-function when $function is empty in com_modules, No data-function in com_scheduler
grafik

Remove Modal view

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • [x ] No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • [ x] No documentation changes for manual.joomla.org needed

@chmst
Copy link
Contributor Author

chmst commented Oct 14, 2022

Hopefully thats correct now; removed wrong indents

@Quy
Copy link
Contributor

Quy commented Jan 19, 2023

Before PR:
38959-heading

After PR (missing heading & button):
38959-new-button

@chmst
Copy link
Contributor Author

chmst commented Jan 20, 2023

Fix toolbar, thank you @Quy

@Quy
Copy link
Contributor

Quy commented Jan 20, 2023

I have tested this item ✅ successfully on ca16170


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38959.

@viocassel
Copy link
Contributor

I have tested this item ✅ successfully on e957027


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38959.

@richard67
Copy link
Member

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38959.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Feb 15, 2023
@fancyFranci fancyFranci merged commit d119a86 into joomla:4.2-dev Feb 22, 2023
@fancyFranci fancyFranci added this to the Joomla! 4.2.9 milestone Feb 22, 2023
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Feb 22, 2023
@fancyFranci
Copy link
Contributor

Thank you for cleaning this up!

richard67 added a commit to richard67/joomla-cms that referenced this pull request Mar 4, 2023
richard67 added a commit to richard67/joomla-cms that referenced this pull request Mar 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants