-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix display of data-function #38959
Merged
Merged
Fix display of data-function #38959
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Quy
reviewed
Oct 14, 2022
Co-authored-by: Quy <quy@nomonkeybiz.com>
richard67
reviewed
Oct 14, 2022
Hopefully thats correct now; removed wrong indents |
Fix toolbar, thank you @Quy |
I have tested this item ✅ successfully on ca16170 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38959. |
I have tested this item ✅ successfully on e957027 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38959. |
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38959. |
Thank you for cleaning this up! |
richard67
added a commit
to richard67/joomla-cms
that referenced
this pull request
Mar 4, 2023
2 tasks
richard67
added a commit
to richard67/joomla-cms
that referenced
this pull request
Mar 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue #38958
Open: removing modal from com_sheduler.
Summary of Changes
Fix display of data-function in com_modules, remove data-function in com_scheduler
Remove modal view
Testing Instructions
Compare the html code of Select screens of com_modules and com_scheduler
Try to find a situation where a modal view is missing.
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
No data-function when $function is empty in com_modules, No data-function in com_scheduler
Remove Modal view
Link to documentations
Please select:
Documentation link for docs.joomla.org:
[x ] No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
[ x] No documentation changes for manual.joomla.org needed