[4.2] contact fields remove layout override

[brianteeman]

com_contact has two types of fields mail and contact. mail are for fields that are added to the contact form. contact is for fields that are displayed with the contact details.

at some point in time a layout override was added for this. Its fubar and not actually needed because the rendering of the different field contexts is already handled in the views (defaulkt_form and default_custom_user_fields)

the main issues caused by these overrides is that the contact fields are not rendered the same as they would have been for an article (dt not dl) and the display of subforms is obviously completely wrong.

Steps to reproduce the issue

1. Com content

• Create 3 text fields
• Create 1 subform field containing the 3 text fields
• create article and complete the fields

2. com contact - context contact

• Create 3 text fields
• Create 1 subform field containing the 3 text fields

3. com contact - context mail

• Create 3 text fields
• Create 1 subform field containing the 3 text fields

4. test

• create contact and complete the fields
• compare the display of the fields in the front end

Expected result

Fields are displayed the same across the two components

Actual result

com_contact has a field layout override that uses a dl etc instead of a ul AND the subform display is fubar

com_content

com_contact

After PR

Additional comments

@richard67 I cant remember if i am supposed to add these removed files to script.php or if you deal with it?

@bembelimen @roland-d to me this is a bug fix and should be in 4.1 but I suspect you will say it needs to go in 4.2?

[richard67]

@richard67 I cant remember if i am supposed to add these removed files to script.php or if you deal with it?

@brianteeman I will deal with it.

[joomla-bot]

This pull requests has been automatically converted to the PSR-12 coding standard.

[brianteeman]

looks like the psr12 pull requests completely messed up this pr :(

[brianteeman]

fixed the issues from the psr12 pr

[Quy]

I have tested this item ✅ successfully on ba7d87f

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37716.}

[viocassel]

I have tested this item ✅ successfully on ba7d87f

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37716.}

[richard67]

RTC

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37716.}

[richard67]

@brianteeman Could you solve the conflict? Thanks in advance.

[brianteeman]

@brianteeman Could you solve the conflict? Thanks in advance.

done as requested

[richard67]

RTC is still valid because the commit after the human tests was a clean conflict resolution. The conflict was in file "render.php" and came from PR #39616 , which changed array syntax in that file which is then removed with this PR here.

[fancyFranci]

Thank you! :)

[laoneo]

This pr broke the way custom fields are rendered in mails. Now the contain the HTML code as when they get rendered in a web page. Please test #40557 which restores the old behavior while keeping the new feature from this pr when rendered in a web page.