Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[4.2] Change task plugin to service provider #37954

Merged
merged 10 commits into from
Jun 8, 2022
Merged

[4.2] Change task plugin to service provider #37954

merged 10 commits into from
Jun 8, 2022

Conversation

laoneo
Copy link
Member

@laoneo laoneo commented Jun 1, 2022 •
edited
Loading

Summary of Changes

Changes the requests task plugin to service provider. Additionally some untranslated strings are fixed and the manifest file is cleaned up.

The change in the TaskPluginTrait.php is needed, so forms are loaded from the forms folder in the root of the plugin.

Testing Instructions

  • Create a GET request task in the task scheduler extension
  • Run the task manually

Actual result BEFORE applying this Pull Request

All works.

Expected result AFTER applying this Pull Request

All works.

@richard67
Copy link
Member

richard67 commented Jun 1, 2022 •
edited
Loading

Somehow this PR seems to show unrelated changes on GitHub, as if the branch had been rebased.

Sorry, was looking at the wrong PR.

@heelc29
Copy link
Contributor

heelc29 commented Jun 2, 2022

Can you remove the version attribute?

joomla-cms/plugins/task/requests/requests.xml

Line 2 in 4d793c9

<extension version="4.1" type="plugin" group="task" method="upgrade">

laoneo and others added 2 commits June 2, 2022 06:46
@laoneo @heelc29
Update plugins/task/requests/src/Extension/Requests.php
67357ab 
Co-authored-by: heelc29 <66922325+heelc29@users.noreply.github.com>
@laoneo
version
df3caf9
@laoneo
Copy link
Member Author

laoneo commented Jun 2, 2022

done

@roland-d roland-d merged commit d56377b into joomla:4.2-dev Jun 8, 2022
@roland-d
Copy link
Contributor

roland-d commented Jun 8, 2022

Thanks everybody

@roland-d roland-d deleted the j4/plugins/task/request branch June 8, 2022 07:19
@roland-d roland-d added this to the Joomla 4.2.0 milestone Jun 8, 2022
@laoneo laoneo mentioned this pull request Jun 8, 2022
Merged
richard67 added a commit to richard67/joomla-cms that referenced this pull request Jun 12, 2022
@richard67
Add deleted file from PR joomla#37954
f80f2f4
richard67 added a commit to richard67/joomla-cms that referenced this pull request Jun 12, 2022
@richard67
Add deleted file from PR joomla#37954
fcb8216
richard67 added a commit to richard67/joomla-cms that referenced this pull request Jun 12, 2022
@richard67
Add deleted file from PR joomla#37954
d1d541b
richard67 added a commit to richard67/joomla-cms that referenced this pull request Jun 12, 2022
@richard67
Add deleted file from PR joomla#37954
5d5e589
richard67 added a commit to richard67/joomla-cms that referenced this pull request Jun 12, 2022
@richard67
Add deleted file from PR joomla#37954
6ab0353
@richard67 richard67 mentioned this pull request Jun 12, 2022
Merged
richard67 added a commit to richard67/joomla-cms that referenced this pull request Jun 12, 2022
@richard67
Add deleted file from PR joomla#37954
004bbb5
richard67 added a commit to richard67/joomla-cms that referenced this pull request Jun 12, 2022
@richard67
Add deleted file from PR joomla#37954
cdb55fa
richard67 added a commit to richard67/joomla-cms that referenced this pull request Jun 16, 2022
@richard67
Add deleted file from PR joomla#37954
5f63dc5
richard67 added a commit to richard67/joomla-cms that referenced this pull request Jun 16, 2022
@richard67
Add deleted file from PR joomla#37954
b8e49ae
richard67 added a commit to richard67/joomla-cms that referenced this pull request Jun 16, 2022
@richard67
Add deleted file from PR joomla#37954
ff83a11
richard67 added a commit to richard67/joomla-cms that referenced this pull request Jun 16, 2022
@richard67
Add deleted file from PR joomla#37954
e21e281
richard67 added a commit to richard67/joomla-cms that referenced this pull request Jun 19, 2022
@richard67
Add deleted file from PR joomla#37954
ca3d6e2
richard67 added a commit to richard67/joomla-cms that referenced this pull request Jun 19, 2022
@richard67
Add deleted file from PR joomla#37954
50a1d2f
richard67 added a commit to richard67/joomla-cms that referenced this pull request Jun 20, 2022
@richard67
Add deleted file from PR joomla#37954
ff63902
richard67 added a commit to richard67/joomla-cms that referenced this pull request Jun 20, 2022
@richard67
Add deleted file from PR joomla#37954
d4b86cd
roland-d pushed a commit that referenced this pull request Jun 20, 2022
@richard67
[4.2] Update deleted files and folders for 4.2.0-beta2 (#38039)
8806607 
* Add deleted file from PR #37954

* Add deleted files from PR's #37928 , #37929 and #37947

* Add deleted files and folders from PR #38065

* Fix forgotten section header for folders

* Add deleted file from PR #38097
richard67 added a commit to richard67/joomla-cms that referenced this pull request Jun 28, 2022
@richard67
Add deleted file from PR joomla#37954
e1aabf3
richard67 added a commit to richard67/joomla-cms that referenced this pull request Jun 28, 2022
@richard67
Add deleted file from PR joomla#37954
c4068b4
richard67 added a commit to richard67/joomla-cms that referenced this pull request Jun 28, 2022
@richard67
Add deleted file from PR joomla#37954
0fb7ae5
richard67 added a commit to richard67/joomla-cms that referenced this pull request Jun 28, 2022
@richard67
Add deleted file from PR joomla#37954
6c67fb0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brianteeman brianteeman brianteeman left review comments

@HLeithner HLeithner HLeithner left review comments

@richard67 richard67 richard67 left review comments

@heelc29 heelc29 heelc29 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Joomla! 4.2.0
Development

Successfully merging this pull request may close these issues.
7 participants
@laoneo @richard67 @heelc29 @roland-d @brianteeman @HLeithner @joomla-cms-bot