Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[4.2] Convert versionable plugin to services #37929

Merged
merged 8 commits into from
Jun 12, 2022
Merged

[4.2] Convert versionable plugin to services #37929

merged 8 commits into from
Jun 12, 2022

Conversation

laoneo
Copy link
Member

@laoneo laoneo commented May 30, 2022

Summary of Changes

Change versions plugin to service provider. Did also some code style cleanup.

Testing Instructions

  • Enable versions in the articles global options
  • Open the article form
  • Set a title
  • Set a description
  • Save (NOT close) the article
  • Click on the versions button

Actual result BEFORE applying this Pull Request

Different versions are displayed.

Expected result AFTER applying this Pull Request

Different versions are displayed.

laoneo and others added 3 commits June 5, 2022 12:59
@laoneo @heelc29
Update plugins/behaviour/versionable/src/Extension/Versionable.php
fb38b47 
Co-authored-by: heelc29 <66922325+heelc29@users.noreply.github.com>
@laoneo @heelc29
Update plugins/behaviour/versionable/src/Extension/Versionable.php
4f0d4cd 
Co-authored-by: heelc29 <66922325+heelc29@users.noreply.github.com>
@laoneo
language in manifest
5af6eaa
@sandewt
Copy link
Contributor

sandewt commented Jun 6, 2022

[4.2] Convert versionable plugin to services

Just a question. Does this conversion also work in [4.1] ?

@laoneo
Copy link
Member Author

laoneo commented Jun 7, 2022

[4.2] Convert versionable plugin to services

Just a question. Does this conversion also work in [4.1] ?

Basically it should also work on 4.1. Why?

@sandewt
Copy link
Contributor

sandewt commented Jun 7, 2022

Basically it should also work on 4.1. Why?

I'm building some plugins for 4.1.

@laoneo
Copy link
Member Author

laoneo commented Jun 7, 2022

Ah yes, that should work too.

joomdonation
joomdonation reviewed Jun 11, 2022
View reviewed changes
Copy link
Contributor

@joomdonation joomdonation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and worked OK. Just small questions with the code and I will mark my test result.

plugins/behaviour/versionable/src/Extension/Versionable.php Show resolved Hide resolved
plugins/behaviour/versionable/src/Extension/Versionable.php Show resolved Hide resolved
@joomdonation
Copy link
Contributor

I have tested this item ✅ successfully on 804666b

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37929.

1 similar comment
@sandewt
Copy link
Contributor

sandewt commented Jun 11, 2022

I have tested this item ✅ successfully on 804666b

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37929.

@Quy
Copy link
Contributor

Quy commented Jun 11, 2022

RTC

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37929.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Jun 11, 2022
@roland-d roland-d merged commit 6404d34 into joomla:4.2-dev Jun 12, 2022
@roland-d roland-d deleted the j4/plugins/versions branch June 12, 2022 09:12
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Jun 12, 2022
@roland-d
Copy link
Contributor

Thanks everybody

@roland-d roland-d added this to the Joomla 4.2.0 milestone Jun 12, 2022
richard67 added a commit to richard67/joomla-cms that referenced this pull request Jun 12, 2022
@richard67
Add deleted files from PR's joomla#37928 , joomla#37929 and joomla#37947
17e6f58
richard67 added a commit to richard67/joomla-cms that referenced this pull request Jun 12, 2022
@richard67
Add deleted files from PR's joomla#37928 , joomla#37929 and joomla#37947
b32f536
richard67 added a commit to richard67/joomla-cms that referenced this pull request Jun 12, 2022
@richard67
Add deleted files from PR's joomla#37928 , joomla#37929 and joomla#37947
189027b
@richard67 richard67 mentioned this pull request Jun 12, 2022
Merged
richard67 added a commit to richard67/joomla-cms that referenced this pull request Jun 12, 2022
@richard67
Add deleted files from PR's joomla#37928 , joomla#37929 and joomla#37947
f17f819
richard67 added a commit to richard67/joomla-cms that referenced this pull request Jun 12, 2022
@richard67
Add deleted files from PR's joomla#37928 , joomla#37929 and joomla#37947
fc50bf3
richard67 added a commit to richard67/joomla-cms that referenced this pull request Jun 16, 2022
@richard67
Add deleted files from PR's joomla#37928 , joomla#37929 and joomla#37947
26eed08
richard67 added a commit to richard67/joomla-cms that referenced this pull request Jun 16, 2022
@richard67
Add deleted files from PR's joomla#37928 , joomla#37929 and joomla#37947
0dafaaf
richard67 added a commit to richard67/joomla-cms that referenced this pull request Jun 16, 2022
@richard67
Add deleted files from PR's joomla#37928 , joomla#37929 and joomla#37947
c760fe8
richard67 added a commit to richard67/joomla-cms that referenced this pull request Jun 16, 2022
@richard67
Add deleted files from PR's joomla#37928 , joomla#37929 and joomla#37947
ba5a951
richard67 added a commit to richard67/joomla-cms that referenced this pull request Jun 19, 2022
@richard67
Add deleted files from PR's joomla#37928 , joomla#37929 and joomla#37947
f65138a
richard67 added a commit to richard67/joomla-cms that referenced this pull request Jun 19, 2022
@richard67
Add deleted files from PR's joomla#37928 , joomla#37929 and joomla#37947
48680bb
richard67 added a commit to richard67/joomla-cms that referenced this pull request Jun 20, 2022
@richard67
Add deleted files from PR's joomla#37928 , joomla#37929 and joomla#37947
b03b015
richard67 added a commit to richard67/joomla-cms that referenced this pull request Jun 20, 2022
@richard67
Add deleted files from PR's joomla#37928 , joomla#37929 and joomla#37947
b2c8c96
roland-d pushed a commit that referenced this pull request Jun 20, 2022
@richard67
[4.2] Update deleted files and folders for 4.2.0-beta2 (#38039)
8806607 
* Add deleted file from PR #37954

* Add deleted files from PR's #37928 , #37929 and #37947

* Add deleted files and folders from PR #38065

* Fix forgotten section header for folders

* Add deleted file from PR #38097
richard67 added a commit to richard67/joomla-cms that referenced this pull request Jun 28, 2022
@richard67
Add deleted files from PR's joomla#37928 , joomla#37929 and joomla#37947
4b87c7e
richard67 added a commit to richard67/joomla-cms that referenced this pull request Jun 28, 2022
@richard67
Add deleted files from PR's joomla#37928 , joomla#37929 and joomla#37947
e32ca4f
richard67 added a commit to richard67/joomla-cms that referenced this pull request Jun 28, 2022
@richard67
Add deleted files from PR's joomla#37928 , joomla#37929 and joomla#37947
9f9438a
richard67 added a commit to richard67/joomla-cms that referenced this pull request Jun 28, 2022
@richard67
Add deleted files from PR's joomla#37928 , joomla#37929 and joomla#37947
56312d2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joomdonation joomdonation joomdonation left review comments

@brianteeman brianteeman brianteeman left review comments

@sandewt sandewt sandewt left review comments

@heelc29 heelc29 heelc29 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Joomla! 4.2.0
Development

Successfully merging this pull request may close these issues.
8 participants
@laoneo @sandewt @joomdonation @Quy @roland-d @brianteeman @heelc29 @joomla-cms-bot