Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.0] Replace filter.condition by filter.published in com_content #30467

Merged
merged 4 commits into from
Nov 14, 2020

Conversation

chmst
Copy link
Contributor

@chmst chmst commented Aug 24, 2020

Started here #30459 .

Summary of Changes

In com_content and related modules, filter.condition is used for filtering publishedm unpublished, archived, trashed data.
This might cause problems when 3rd party extension set filters for articles.
This PR sets back the name to filter.published in J3. It does not change the behavour in any way.

Testing Instructions

Testing is not as easy, as these filters are used in different ways. The test is successful, if nothing in Joomla frontend changes with the patch applied.

You should have some content i.e. testing sample data - categories and articles, some archived, some published, some unpublished and some trashed.
And you should have modules for every kind of articles.

Now check in the frontend: The modules must show only published articles. Your blogs should show only published articles.

@chmst chmst changed the title Replace filter.condition by filter.published in com_content [4.0] Replace filter.condition by filter.published in com_content Aug 24, 2020
@ghost
Copy link

ghost commented Sep 7, 2020

I have tested this item ✅ successfully on 01c7762


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30467.

@Quy
Copy link
Contributor

Quy commented Sep 7, 2020

Remove?

$model->setState('filter.condition', 1);

See:

$model->setState('filter.published', 1);

@Quy Quy added the Updates Requested Indicates that this pull request needs an update from the author and should not be tested. label Sep 10, 2020
@karo3
Copy link
Contributor

karo3 commented Oct 17, 2020

I have tested this item ✅ successfully on 01c7762


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30467.

@richard67
Copy link
Member

@chmst Could you check @Quy 's comment above? Thanks in advance.

@chmst
Copy link
Contributor Author

chmst commented Nov 9, 2020

@Quy could you please remove the "update request" label from this PR, as the requested changes are made in #31155?

@alikon alikon removed the Updates Requested Indicates that this pull request needs an update from the author and should not be tested. label Nov 9, 2020
richard67 pushed a commit that referenced this pull request Nov 14, 2020
As required in #30467 the filter.condition is changed to filter.published.
@richard67
Copy link
Member

Previous test results are still valid since last commit was only a clean branch update => RTC.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30467.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Nov 14, 2020
@richard67
Copy link
Member

Good to be merged .. I just gave it a test, too.

@richard67 richard67 merged commit 13973de into joomla:4.0-dev Nov 14, 2020
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Nov 14, 2020
@richard67
Copy link
Member

Thanks!

@richard67 richard67 added this to the Joomla 4.0 milestone Nov 14, 2020
@chmst chmst deleted the replace-filter-condition branch July 7, 2022 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants