Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.0] Fix mod_articles_latest #30459

Merged
merged 1 commit into from
Aug 25, 2020
Merged

Conversation

chmst
Copy link
Contributor

@chmst chmst commented Aug 23, 2020

Pull Request for Issue #30445 .

Summary of Changes

Add a filter.condition for published articles to mod_articles_latest.

Testing Instructions

See the related #30445 .

Actual result BEFORE applying this Pull Request

Unpublished articles are shown in the Module mod_articles_latest.

Expected result AFTER applying this Pull Request

Only published articles are shown in the Module mod_articles_latest.

Documentation Changes Required

no

@chmst chmst changed the title Fix mod_articles_latest [4.0] Fix mod_articles_latest Aug 23, 2020
@SharkyKZ
Copy link
Contributor

Is there any reason why state/condition filter is called filter.published in backend and filter.condition in backend?

@chmst
Copy link
Contributor Author

chmst commented Aug 24, 2020

@SharkyKZ I don't know. The filter should have the same name as in J3.x for 3rd party extensions. This is a quick fix for the issue.

@paternax
Copy link

It works like it should with this patch

@sandewt
Copy link
Contributor

sandewt commented Aug 24, 2020

I have tested this item ✅ successfully on c1498f4

Joomla! 4.0.0-beta4-dev Development [ Mañana ] 29-July-2020 18:21 GMT

See comment.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30459.

@richard67
Copy link
Member

It works like it should with this patch

@paternax Does it mean you have tested this pull resuest with success? If so, could you mark your test result on the issue tracker? Just follow this link https://issues.joomla.org/tracker/joomla-cms/30459 and then use the "Test this" button. Then select your appropriate test result ("succes" in this case) and submitt. Thanks in advance.

@sandewt
Copy link
Contributor

sandewt commented Aug 24, 2020

Is there any reason why state/condition filter is called filter.published in backend and filter.condition in backend?

$model->setState('filter.published', 1) DOESN'T WORK !

This following code works as alternative for: $model->setState('filter.condition', 1);

use Joomla\Component\Content\Administrator\Extension\ContentComponent;
...
$model->setState('filter.condition', ContentComponent::CONDITION_PUBLISHED);

[EDIT]


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30459.

@SharkyKZ
Copy link
Contributor

@chmst So it should be filter.published. I guess #29235 just forgot to make replacements in frontend models. Maybe @bembelimen or @HLeithner knows.

@chmst
Copy link
Contributor Author

chmst commented Aug 24, 2020

Then it would be good th have this merged soon. And make complete change for the filter name.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30459.

@HLeithner
Copy link
Member

Yes seems like we oversee this, it should be filter.published iirc there should be no condition keyword more in frontend.

@paternax
Copy link

I have tested this item ✅ successfully on c1498f4


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30459.

@richard67
Copy link
Member

@HLeithner So this one here is ok so far, and the rest can be fixed with a new PR?

@chmst Can you do that?

@richard67
Copy link
Member

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30459.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Aug 24, 2020
@chmst
Copy link
Contributor Author

chmst commented Aug 24, 2020

@richard67 I'll prepare a PR for that

@wilsonge wilsonge merged commit b809711 into joomla:4.0-dev Aug 25, 2020
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Aug 25, 2020
@wilsonge
Copy link
Contributor

Merging this one as above then. Thanks!

@wilsonge wilsonge added this to the Joomla 4.0 milestone Aug 25, 2020
@zero-24 zero-24 deleted the fix-articles-latest branch August 25, 2020 17:03
drmenzelit pushed a commit to drmenzelit/joomla-cms that referenced this pull request Aug 31, 2020
infograf768 added a commit that referenced this pull request Sep 4, 2020
* First step to make newsflash horizontal

* [4.0] Fix Alert double error display in Installation

* seperating multiple messages with border top

* Increase minimum length

* Fix meter displaying complete message prematurely

* Add strenthmeter attribute to installation

* Change meter values to display green when password requirements are met

* [4.0] {Cassiopea] Implementing Password length/meter

* [4.0] Fix Fieldset description display (#30435)

* [4.0] Url Language Code is not a prefix (#30440)

* [4.0] URL LANGUAGE CODE is not a prefix

* modified desc as suggested

* [4.0] Implementing display of fieldset descriptions for fieldset
children

* Taking off description

* scss cs

* use @Quy suggestion

* file cs

* [4.0] Media field fix (#30455)

* fix

* typo, (well nothing new)

* Allow media fields in subforms

- Cleanup Media field
- Expose initilazation method of Bootstrpa Modlas to a Joomla.Bootstrap object
- Initilise Modlas on the lifecycle of the Custom Element

* Paleolithic js mode only in the legacy…

* CS

* Proper check

* Pffff

* Update joomla-field-media.w-c.es6.js

* [4.0] Convert icon used for jgrid defaults to fas fa- (#30464)

* make icon-circle use fa-circle

* allows for including icon- in call

* move fa-fw to last class to fit convention (#30469)

* [4.0] Long labels wrapping (#30474)

When we have fields displayed in columns with the label displayed above the input there is a width limit of 240px on the label.

This results in long labels wrapping when it is not needed as the column is wider than 240px.

In english we dont see this is many places but the easiest is in the __configure edit screen_  fields

This simple PR changes the label width to 100% when the fields are displayed in columns like this.

As this is an scss change you will need to `node build.js --compile-css` in order to test

### Before

### After

* Fix mod_articles_latest (#30459)

* [4.0] Add a parameter for "back-to-top" button in Cassiopeia (#30441)

* [4.0] Add a parameter for back-to-top button in Cassiopeia

Added a parameter to show / hide the back-to-top button in Cassiopeia.
Currently the footer appears when a module has been published on position "footer". And the back-to-top only appears if the footer is visible. Since the footer is part of the grid, it is not easy to move the back-to-top outside the grid.

Now it is possible to decide to have a back-to-top or not. If yes, the footer will be rendered showing the button, independently if there is a module in the position footer.
It is also possible to show only modules (switch back-to-top off) or modules and back-to-top (switch on).

* Added smooth scrolling

Add smooth scrolling taking in account the preferences of the user (reduced motion).
Improve  language file.

* Correct height and position of back-to-top button

* Correct code style

* Correct code style 2

* Change smooth scrolling behavior to take in account reduced motion preferences

* Language file corrected, language string changed to match others

* Update language/en-GB/tpl_cassiopeia.ini

Link instead button

Co-authored-by: Brian Teeman <brian@teeman.net>

* Update templates/cassiopeia/scss/blocks/_global.scss

Comment for smooth scroll

Co-authored-by: Brian Teeman <brian@teeman.net>

Co-authored-by: Brian Teeman <brian@teeman.net>

* fix improper family name. (#30481)

* [4.0] update helptoc (#30490)

* [4.0] update helptoc

Removes the string for the expired cache page that no longer exists and removes it from the index displayed on the left hand side in the help page

* api

* [4.0] Add new permissions-policy to the HTTPHeaders Plugin (#30491)

* add permissions-policy

* add Permissions-Policy to the dropdown

* alpha order

* [4.0] Error when changing status of tagged content items (#30466)

* Correct column name

* Fix changing UCM state

* [4.0] br tag (#30503)

* [4.0] br tag

In Joomla 4 we use `<br>` not `<br />`

* bad grep

* [4.0] Remove old search component (#30506)

* [4.0] Remove old search component

The regular search component is not in J4

This pr removes reference to it in the help system
`administrator/index.php?option=com_admin&view=help`

* revert

* [4.0] Help Dashboard (#30508)

* [4.0] Help Dashboard

This PR makes multiple changes to the help dashboard. In order of importance they are.

- Created a new section "Start Here"
- Moved "Joomla Help" to the "Start Here" section to give it greater priority as it really is the first place you should look for help
- Removed target=_blank from "Joomla Help"
- Moved "Documentation Wiki" from "Resources" to the top of "Additional Help"

* deduplicate

* compass icon

* Moved css for mod_articles_news to media folder

User webAsset Manager to load specific css for module

* Move web asset call to horizontal.php

Co-authored-by: Jean-Marie Simonet <infografjms@gmail.com>
Co-authored-by: Quy <quy@fluxbb.org>
Co-authored-by: dGrammatiko <d.grammatiko@gmail.com>
Co-authored-by: Bear <programming@hallhome.us>
Co-authored-by: Brian Teeman <brian@teeman.net>
Co-authored-by: Christiane Maier-Stadtherr <dev@chmst.de>
Co-authored-by: Tobias Zulauf <zero-24@users.noreply.github.com>
Co-authored-by: SharkyKZ <sharkykz@gmail.com>
sakiss pushed a commit to sakiss/joomla-cms that referenced this pull request Oct 16, 2020
sakiss pushed a commit to sakiss/joomla-cms that referenced this pull request Oct 16, 2020
* First step to make newsflash horizontal

* [4.0] Fix Alert double error display in Installation

* seperating multiple messages with border top

* Increase minimum length

* Fix meter displaying complete message prematurely

* Add strenthmeter attribute to installation

* Change meter values to display green when password requirements are met

* [4.0] {Cassiopea] Implementing Password length/meter

* [4.0] Fix Fieldset description display (joomla#30435)

* [4.0] Url Language Code is not a prefix (joomla#30440)

* [4.0] URL LANGUAGE CODE is not a prefix

* modified desc as suggested

* [4.0] Implementing display of fieldset descriptions for fieldset
children

* Taking off description

* scss cs

* use @Quy suggestion

* file cs

* [4.0] Media field fix (joomla#30455)

* fix

* typo, (well nothing new)

* Allow media fields in subforms

- Cleanup Media field
- Expose initilazation method of Bootstrpa Modlas to a Joomla.Bootstrap object
- Initilise Modlas on the lifecycle of the Custom Element

* Paleolithic js mode only in the legacy…

* CS

* Proper check

* Pffff

* Update joomla-field-media.w-c.es6.js

* [4.0] Convert icon used for jgrid defaults to fas fa- (joomla#30464)

* make icon-circle use fa-circle

* allows for including icon- in call

* move fa-fw to last class to fit convention (joomla#30469)

* [4.0] Long labels wrapping (joomla#30474)

When we have fields displayed in columns with the label displayed above the input there is a width limit of 240px on the label.

This results in long labels wrapping when it is not needed as the column is wider than 240px.

In english we dont see this is many places but the easiest is in the __configure edit screen_  fields

This simple PR changes the label width to 100% when the fields are displayed in columns like this.

As this is an scss change you will need to `node build.js --compile-css` in order to test

### Before

### After

* Fix mod_articles_latest (joomla#30459)

* [4.0] Add a parameter for "back-to-top" button in Cassiopeia (joomla#30441)

* [4.0] Add a parameter for back-to-top button in Cassiopeia

Added a parameter to show / hide the back-to-top button in Cassiopeia.
Currently the footer appears when a module has been published on position "footer". And the back-to-top only appears if the footer is visible. Since the footer is part of the grid, it is not easy to move the back-to-top outside the grid.

Now it is possible to decide to have a back-to-top or not. If yes, the footer will be rendered showing the button, independently if there is a module in the position footer.
It is also possible to show only modules (switch back-to-top off) or modules and back-to-top (switch on).

* Added smooth scrolling

Add smooth scrolling taking in account the preferences of the user (reduced motion).
Improve  language file.

* Correct height and position of back-to-top button

* Correct code style

* Correct code style 2

* Change smooth scrolling behavior to take in account reduced motion preferences

* Language file corrected, language string changed to match others

* Update language/en-GB/tpl_cassiopeia.ini

Link instead button

Co-authored-by: Brian Teeman <brian@teeman.net>

* Update templates/cassiopeia/scss/blocks/_global.scss

Comment for smooth scroll

Co-authored-by: Brian Teeman <brian@teeman.net>

Co-authored-by: Brian Teeman <brian@teeman.net>

* fix improper family name. (joomla#30481)

* [4.0] update helptoc (joomla#30490)

* [4.0] update helptoc

Removes the string for the expired cache page that no longer exists and removes it from the index displayed on the left hand side in the help page

* api

* [4.0] Add new permissions-policy to the HTTPHeaders Plugin (joomla#30491)

* add permissions-policy

* add Permissions-Policy to the dropdown

* alpha order

* [4.0] Error when changing status of tagged content items (joomla#30466)

* Correct column name

* Fix changing UCM state

* [4.0] br tag (joomla#30503)

* [4.0] br tag

In Joomla 4 we use `<br>` not `<br />`

* bad grep

* [4.0] Remove old search component (joomla#30506)

* [4.0] Remove old search component

The regular search component is not in J4

This pr removes reference to it in the help system
`administrator/index.php?option=com_admin&view=help`

* revert

* [4.0] Help Dashboard (joomla#30508)

* [4.0] Help Dashboard

This PR makes multiple changes to the help dashboard. In order of importance they are.

- Created a new section "Start Here"
- Moved "Joomla Help" to the "Start Here" section to give it greater priority as it really is the first place you should look for help
- Removed target=_blank from "Joomla Help"
- Moved "Documentation Wiki" from "Resources" to the top of "Additional Help"

* deduplicate

* compass icon

* Moved css for mod_articles_news to media folder

User webAsset Manager to load specific css for module

* Move web asset call to horizontal.php

Co-authored-by: Jean-Marie Simonet <infografjms@gmail.com>
Co-authored-by: Quy <quy@fluxbb.org>
Co-authored-by: dGrammatiko <d.grammatiko@gmail.com>
Co-authored-by: Bear <programming@hallhome.us>
Co-authored-by: Brian Teeman <brian@teeman.net>
Co-authored-by: Christiane Maier-Stadtherr <dev@chmst.de>
Co-authored-by: Tobias Zulauf <zero-24@users.noreply.github.com>
Co-authored-by: SharkyKZ <sharkykz@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants