[4.0] Update check alerts

[brianteeman]

In J3 the quickicon for the new version etc where hidden in the bottom left of the control panel so we had a popup alert as well. As the quickicons are now bigger and right at the top we don't need the popup as well. Also you will see that the popups over wrote each other so they were even more useless

This PR removes the popup and associated strings and ensures that the icons get the red danger instead of the brown warning and also standardises the 3 strings so that the count is in the same place.

Testing Instructions

Will require npm i
To test extension updates - install a language and then change the version number in the db
To test joomla updates - create a custom extension server

Before

After

[wilsonge]

If we're removing the scroll to top here (which is fine). Then we can remove the 'requirement' on windows from the top/bottom of the file for the anonymous function as we aren't using it anymore

[brianteeman]

sorry you will have to explain in dummy terms as I really dont understand js

[brianteeman]

Do you just mean change references of (window, document, Joomla); to (document, Joomla);

[wilsonge]

Yes top and bottom of the file

[brianteeman]

@wilsonge I updated jupdatecheck.es6.js as suggested

I didnt see anything in extensionupdatecheck.es6.js to update ??

[wilsonge]

Looks good to me. Yeah I'm not sure exactly why that is - i guess something is theoretically wrong somewhere there :/ but as long as it works :/

[brianteeman]

Thanks

[infograf768]

Note:
Taking off the Messages is not the solution imho. We have an underlying issue.
The same situation happens when one updates many items at the same time: the message only displays for the last item updated.
Here for languages:
Install older packs
de-DE_joomla_lang_full_3.9.5v1.zip
fr-FR_joomla_lang_full_3.9.5v2.zip

This is what you get when you update:

[infograf768]

What I meant is that the ideal for these checks would be to combine the Messages in a unique Warning message with as many items concerned as necessary.

[brianteeman]

That was a side effect bonus of the issue that was being solved here. Please create your own issue for the messages

[wilsonge]

@infograf768 there's definitely a bigger problem to solve in speed of messages being removed. However in this specific case we had both alerts and the warning buttons at the top of the screen. Which meant we had two alerts for the same thing.