Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.0] Login bad error message #29773

Closed
ceford opened this issue Jun 24, 2020 · 3 comments
Closed

[4.0] Login bad error message #29773

ceford opened this issue Jun 24, 2020 · 3 comments

Comments

@ceford
Copy link
Contributor

ceford commented Jun 24, 2020

Steps to reproduce the issue

Upgrade nightly build (today is 2020-06-24). Logout / Login Administrator.

Expected result

Home Dashboard / Control Panel OK

Actual result

There is a stray error message as illustrated:

screen shot 2020-06-24 at 06 06 06

The blue link leads to Urgent privacy requests - the ones I forgot about whilst testing.

System information (as much as possible)

Additional comments

The last thing I did was save Global Configuration after changing default Captcha.

@ReLater
Copy link
Contributor

ReLater commented Jun 24, 2020

See next comment #29773 (comment)

The first part is easy. The lines

"REQUESTFOUND_MESSAGE" => Text::_('PLG_QUICKICON_PRIVACYCHECK_REQUESTFOUND_MESSAGE'),

"REQUESTFOUND_BUTTON" => Text::_('PLG_QUICKICON_PRIVACYCHECK_REQUESTFOUND_BUTTON'),

are missing here:
https://github.com/joomla/joomla-cms/blob/4.0-dev/plugins/quickicon/privacycheck/privacycheck.php#L63-L65

Then I get:
24-06-_2020_16-55-54

  1. part could be to chnage

PLG_QUICKICON_PRIVACYCHECK_REQUESTFOUND_MESSAGE="%s Urgent Privacy Request(s) to manage."

to

PLG_QUICKICON_PRIVACYCHECK_REQUESTFOUND_MESSAGE="urgent Privacy Request(s) to manage."

It's used here(?) .
https://github.com/joomla/joomla-cms/blob/4.0-dev/build/media_source/plg_quickicon_privacycheck/js/privacycheck.es6.js#L46

I don't know if JS has a sprintf analog and if it should be used here if yes.

@ReLater
Copy link
Contributor

ReLater commented Jun 27, 2020

It looks like the alert message has been removed by @brianteeman on purpose: See #24893

but then the JS logic was brought back some months later by @bembelimen erroneously: See #25570

and 50eae65#diff-e815986c9bc783495edecba9f87d8f84 ( @fancyFranci )

Otherwise we both wouldn't see the alert message concerning privacy requests.

@ceford
Copy link
Contributor Author

ceford commented Oct 14, 2020

I think this problem has gone away

@ceford ceford closed this as completed Oct 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants