Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[4.0] Remove module description popover #24634

Merged
merged 3 commits into from
Apr 22, 2019
Merged

[4.0] Remove module description popover #24634

merged 3 commits into from
Apr 22, 2019

Commits on Apr 18, 2019

  1. [4.0] Remove module description popover 

    When you go to select a NEW module you have a list of all the modules with a very short 90 character truncated description.

If you hover over that description you get a popover with a short 200 character truncated description.

This popover is not accessible - I doubt even most sighted users will know that it even exists as there is no visual indicator that it exists either.

The original reason for the 90 character truncation was back in the day that this was a modal and there was limited space. That is no longer true  but we do need to have some form of truncation as some 3pd write essays for the description ;)

This PR removes the popover and changes the displayed description to the 200 character version
    @brianteeman
    brianteeman committed Apr 18, 2019
    Configuration menu
    Copy the full SHA
    461e557 View commit details
    Browse the repository at this point in the history

  2. keep @Quy happy ;)

    @brianteeman
    brianteeman committed Apr 18, 2019
    Configuration menu
    Copy the full SHA
    e17c18a View commit details
    Browse the repository at this point in the history

  3. Merge branch '4.0-dev' into module_popover

    @jeckodevelopment
    jeckodevelopment authored Apr 18, 2019
    Configuration menu
    Copy the full SHA
    8fc1849 View commit details
    Browse the repository at this point in the history