-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[4.0] Remove module description popover #24634
Conversation
When you go to select a NEW module you have a list of all the modules with a very short 90 character truncated description. If you hover over that description you get a popover with a short 200 character truncated description. This popover is not accessible - I doubt even most sighted users will know that it even exists as there is no visual indicator that it exists either. The original reason for the 90 character truncation was back in the day that this was a modal and there was limited space. That is no longer true but we do need to have some form of truncation as some 3pd write essays for the description ;) This PR removes the popover and changes the displayed description to the 200 character version
@@ -25,17 +24,15 @@ | |||
<?php $link = 'index.php?option=com_modules&task=module.add&eid=' . $item->extension_id; ?> | |||
<?php $name = $this->escape($item->name); ?> | |||
<?php $desc = HTMLHelper::_('string.truncate', $this->escape(strip_tags($item->desc)), 200); ?> | |||
<?php $short_desc = HTMLHelper::_('string.truncate', $this->escape(strip_tags($item->desc)), 90); ?> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove spaces before =
.
I know this has nothing to do with this PR. Please confirm that the link should be on the right side. |
Strange. It was on the right in my test setting the XML value to right |
I confirm your results with the farsi language I am assuming there is an issue with this line of code |
I have tested this item ✅ successfully on 8fc1849 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24634. |
1 similar comment
I have tested this item ✅ successfully on 8fc1849 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24634. |
Status "Ready To Commit". |
So is there any way now of seeing the untruncated description in this view? |
Same as before. In the module itself. In the list view before we showed 90 characters and 200 on hover |
Ahh sorry I missed we were only showing 200 in the popover |
Thanks! |
No problem. I was surprised at the limit in the popover too. |
@Quy
|
Code was OK in 2012. ;) |
When you go to select a NEW module you have a list of all the modules with a very short 90 character truncated description. If you hover over that description you get a popover with a short 200 character truncated description. This popover is not accessible - I doubt even most sighted users will know that it even exists as there is no visual indicator that it exists either. The original reason for the 90 character truncation was back in the day that this was a modal and there was limited space. That is no longer true but we do need to have some form of truncation as some 3pd write essays for the description ;) This PR removes the popover and changes the displayed description to the 200 character version
When you go to select a NEW module you have a list of all the modules with a very short 90 character truncated description.
If you hover over that description you get a popover with a short 200 character truncated description. This can result in a popover that is identical to the text it is supposed to be describing
This popover is not accessible - I doubt even most sighted users will know that it even exists as there is no visual indicator that it exists either.
The original reason for the 90 character truncation was back in the day that this was a modal and there was limited space. That is no longer true but we do need to have some form of truncation as some 3pd write essays for the description ;) so I chose the 200 character limit
This PR removes the popover and changes the displayed description to the 200 character version
I am including the screenshots as I doubt most people even knew the popover existed
Before
After