Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.0] Legend in bold #24322

Merged
merged 6 commits into from
Apr 23, 2019
Merged

[4.0] Legend in bold #24322

merged 6 commits into from
Apr 23, 2019

Conversation

brianteeman
Copy link
Contributor

The style for the legend class used in global configuration and extensions-install is the same as the field labels so it doesnt stand out.

Changing the $normal-weight to $bold-weight fixes that

###Testing
Requires npm i

Before

image

After

image

The style for the legend class used in global configuration and extensions-install is the same as the field labels so it doesnt stand out.

Changing the $normal-weight to $bold-weight fixes that

###Testing
Requires npm i
@Quy
Copy link
Contributor

Quy commented Mar 23, 2019

I have tested this item ✅ successfully on 59fc652


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24322.

@ciar4n
Copy link
Contributor

ciar4n commented Mar 23, 2019

As you are reverting #23927, you can remove the font-weight rather than changing it.

@brianteeman
Copy link
Contributor Author

@ciar4n will do. Your pr shouldnt have been merged (not your fault) - it was too generic

@ciar4n
Copy link
Contributor

ciar4n commented Mar 24, 2019

If #23927 is still required you can move the font weight and size inside a .control-group legend selector.

.control-group legend {
  font-size: 1rem;
  font-weight: $normal-weight;
}

If not then leave as it.

@brianteeman
Copy link
Contributor Author

Thanks for the tip - its not needed yet as the switcher code hasnt been changed yet

@Quy
Copy link
Contributor

Quy commented Mar 29, 2019

I have tested this item ✅ successfully on 3bc743d


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24322.

@ghost ghost added the J4 Issue label Apr 5, 2019
@ghost ghost removed the J4 Issue label Apr 13, 2019
@brianteeman
Copy link
Contributor Author

@wilsonge can this get merged please - its a simple revert

@wilsonge
Copy link
Contributor

What's going on with the originally proposed code in #23888 because originally this was done for that.

@wilsonge wilsonge closed this Apr 23, 2019
@wilsonge wilsonge reopened this Apr 23, 2019
@brianteeman
Copy link
Contributor Author

That was jumping the gun. Current work is in #24463

@wilsonge wilsonge merged commit 80847cc into joomla:4.0-dev Apr 23, 2019
@wilsonge wilsonge added this to the Joomla 4.0 milestone Apr 23, 2019
@brianteeman
Copy link
Contributor Author

thanks

@brianteeman brianteeman deleted the legend branch April 23, 2019 10:29
@wilsonge
Copy link
Contributor

wilsonge commented Apr 23, 2019

Makes sense. Thanks!

fancyFranci pushed a commit to fancyFranci/joomla-cms that referenced this pull request Apr 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants