[4.0] add legend styles in settings #24012
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@infograf768 @C-Lodder What do you think? |
|
I have tested this item 🔴 unsuccessfully on 5d18f97 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24012. |
|
@Razzo1987 You mead to run |
|
The exact command is given in build.js for building scss files.
…On Tue 26 Feb, 2019, 2:33 PM Wojciech Smoliński ***@***.*** wrote:
@Razzo1987 <https://github.com/Razzo1987> You mead to run npm run
build:css after applying this patch - see Setting Up Your Local
Environment
<https://docs.joomla.org/J4.x:Setting_Up_Your_Local_Environment>.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#24012 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AibEyg4vwJkKqHLypwN09KIjLuaVnYqTks5vRPhIgaJpZM4bPmSp>
.
|
|
I have tested this item ✅ successfully on 5d18f97 with npm run build:css works! This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24012. |
|
Related PR #24322 |
|
yes that PR fixes the problem which was a pr that should not have been merged |
ghost
changed the title
|
This should be closed as it was fixed with #24322 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue - Legend styles which existed in J3 are missing, which makes navigation in settings difficult.
Expected result
Actual result