Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[com_fields] Responsive subform.repeatable-table #13769

Merged
merged 5 commits into from
Jan 27, 2017

Conversation

ciar4n
Copy link
Contributor

@ciar4n ciar4n commented Jan 26, 2017

Pull Request for Issue # .

Summary of Changes

This PR makes subform tables responsive, switching from column to row views on smaller screens. This form is used in com_fields however applies to all subform tables

Testing Instructions

Navigate to Content -> Fields -> New. Set 'Type' to 'Checkbox', add a number of values and resize the browser window.

@laoneo This resolves the issue we discussed at the sprint regarding using subform.repeatable-table and smaller screens.

Before Patch

subform1

After Patch

subform2

Documentation Changes Required

None

@ghost
Copy link

ghost commented Jan 26, 2017

I have tested this item ✅ successfully on 6527898


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13769.

@laoneo
Copy link
Member

laoneo commented Jan 27, 2017

I have tested this item ✅ successfully on 6527898

Tested it also with some bigger subform fields and it works superb. Thanks Ciaran!


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13769.

@laoneo
Copy link
Member

laoneo commented Jan 27, 2017

I think it would be a new PR, but can this being applied for all tables to make them responsive?


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13769.

@jeckodevelopment
Copy link
Member

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13769.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Jan 27, 2017
@jeckodevelopment jeckodevelopment added this to the Joomla 3.7.0 milestone Jan 27, 2017
@rdeutz rdeutz merged commit 7c1cc9d into joomla:staging Jan 27, 2017
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Jan 27, 2017
@ciar4n
Copy link
Contributor Author

ciar4n commented Jan 27, 2017

Yes.. there would be no real problem there. All that is required is that the title is added to a data attribute for each td (layouts/joomla/form/field/subform/repeatable-table/section.php).

For some tables there may be to much data to display every column in the row view. Would need to decide what rows to show and what rows to leave out for each table.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants