Sub Form Field styles problems

[hfittipaldi]

Steps to reproduce the issue

Any subform with layout="joomla.form.field.subform.repeatable-table"

Expected result

The form style similar to others. Something like this:

Actual result

A little bit unformatted:

System information (as much as possible)

PHP executando em – Windows NT 10.0 build 15063 (Windows 10) AMD64
Versão do Banco de Dados – 5.7.14
Versão do PHP – 5.6.30
Servidor Web – Apache/2.4.23 (Win64) OpenSSL/1.0.2j PHP/5.6.30
Versão do Joomla – Joomla! 3.7.4 Stable [ Amani ] 25-July-2017 11:11 GMT
Navegador do Usuário – Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/60.0.3112.90 Safari/537.36

Additional comments

[tonypartridge]

So the table outputs in a table fashion. It looks like you just want repeatable.

If this isn't the case provide your whole JForm xml so we can see how you are creating it

[Fedik]

I can confirm, the styling of table layout joomla.form.field.subform.repeatable-table looks really bad.
It has become bad after "flat styling" changes, or around this.

[tonypartridge]

Working ok here... I styled a table yesterday. Is it only a problem in the backend?

…

-- Tony Partridge From: Fedir Zinchuk <notifications@github.com> <notifications@github.com> Reply: joomla/joomla-cms <reply@reply.github.com> <reply@reply.github.com> Date: 20 August 2017 at 17:08:32 To: joomla/joomla-cms <joomla-cms@noreply.github.com> <joomla-cms@noreply.github.com> CC: Tony Partridge <admin@xtech.im> <admin@xtech.im>, Comment <comment@noreply.github.com> <comment@noreply.github.com> Subject: Re: [joomla/joomla-cms] Sub Form Field styles problems (#17589) I can confirm, the styling of table layout

joomla.form.field.subform.repeatable-table looks really bad. It has become bad after "flat styling" changes, or around this. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#17589 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABVgluZImhLVBmpMzsxNhJBONF4vFB2Jks5saFoAgaJpZM4O6tlf> .

[Fedik]

ok, it better in recent update 😄
but still some issue, try:

<field name="sebform1" type="subform" label="subform"
	layout="joomla.form.field.subform.repeatable-table" multiple="true" groupByFieldset="true">
	<form>
		<fieldset name="group1" label="group 1">
			<field type="text" name="text" label="text 1"/>
			<field type="text" name="text2" label="text 2"/>
			<field type="text" name="text3" label="text 3"/>
		</fieldset>
		<fieldset name="group2" label="group 2">
			<field type="text" name="text4" label="text 4"/>
			<field type="textarea" name="textarea" label="textarea"/>
		</fieldset>
	</form>
</field>

yes, in the backend

[ghost]

@Fedik can you create a Pull Request for mentioned Issue?

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17589.}

[Fedik]

I do not have a fix currently,

[ghost]

sorry, now i read again you have an Issue, not PR.

[hfittipaldi]

@Fedik , besides the style problem, do you also have problems with remove an empty field? I'm getting javascript error (Joomla 3.8.3 and 3.8.4-rc)

[Fedik]

@hfittipaldi I do not have the problem with remove an empty field

[hfittipaldi]

Weird. I'm getting "Uncaught TypeError: Cannot read property 'id' of undefined" when I remove an empty record (not field, my bad)

[Quy]

It is because of line 7541 \administrator\templates\isis\css\template.css zeroing the bottom margin. I am not sure of the side-effects to removing it.

.subform-table-layout .control-group,
.subform-table-layout .control-group:last-of-type {
	margin-bottom: 0;
}

[ciar4n]

This CSS was originally added here... #13769

Maybe something has changed since as the issue does not appear to be present in the screenshot of that pr. I'll have a look later.

[ciar4n]

Nothing has changed. Looks like I hadn't considered multiple field in each cell when creating the PR. I'll fix this.

[ciar4n]

PR created.. #20209

[joomla-cms-bot]

Set to "closed" on behalf of @franz-wohlkoenig by The JTracker Application at issues.joomla.org/joomla-cms/17589

[ghost]

closed as having Pull Request #20209