New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[plg_system_stats] Load plugin language files only when needed #11728

Merged

rdeutz merged 3 commits into joomla:staging from andrepereiradasilva:patch-20

Aug 25, 2016

Contributor

andrepereiradasilva commented Aug 22, 2016 •

edited by joomla-cms-bot

Loading

Pull Request for Issue #11714.

Summary of Changes

Only load the plg_system_stats languages files where they are needed.
Example: don't load them on frontend.

For more info see #11714

Testing Instructions

Reproduce

Use latest staging
Enable plugin system stats
Enable debug and debug lang in global config
Enable debug system plugin with all options activated
Go to frontend and check the debug console
Notice JROOT/administrator/language/en-GB/en-GB.plg_system_stats.ini language file is loaded.

Test patch

Apply patch
Repeat the steps above and check JROOT/administrator/language/en-GB/en-GB.plg_system_stats.ini language file is NOT loaded.
Check plugin work as before in admin.

Documentation Changes Required

None.

andrepereiradasilva added 2 commits

August 22, 2016 14:17


          Load plugin language files only when needed (if plugin enabled and us…

9c4a97f

…er in administrator client)


          Update stats.php

b29076d

joomla-cms-bot added the PR-staging label

andrepereiradasilva mentioned this pull request

Plugins load always the language file in the frontend (when autoloadLanguage set to yes) #11714

Closed

mbabker reviewed

View reviewed changes

plugins/system/stats/stats.php

@@ @@ -49,7 +49,7 @@ class PlgSystemStats extends JPlugin @@
               	 * @var    boolean
               	 * @since  3.5
               	 */
-              	protected $autoloadLanguage = true;
+              	protected $autoloadLanguage = false;

Contributor

mbabker Aug 22, 2016

Might as well remove the var then as now it matches the parent declaration 100%.


          remove autoloadLanguage property and use this

d0e74ae

bhavikpatel10 commented Aug 23, 2016

I have tested and it's working now.

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11728.}

2 similar comments

bhavikpatel10 commented Aug 23, 2016

I have tested and it's working now.

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11728.}

bhavikpatel10 commented Aug 23, 2016

I have tested and it's working now.

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11728.}

bhavikpatel10 commented Aug 23, 2016

I have tested this item ✅ successfully on d0e74ae

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11728.}

1 similar comment

truptikagathara commented Aug 23, 2016

I have tested this item ✅ successfully on d0e74ae

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11728.}

Contributor

zero-24 commented Aug 23, 2016

RTC

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11728.}

joomla-cms-bot added the RTC label

brianteeman added this to the Joomla 3.6.3 milestone

rdeutz merged commit eca1bc5 into joomla:staging

joomla-cms-bot removed the RTC label

andrepereiradasilva deleted the patch-20 branch

August 25, 2016 20:51

roland-d pushed a commit to roland-d/joomla-cms that referenced this pull request


          [plg_system_stats] Load plugin language files only when needed (jooml…

2a09950

…a#11728)

* Load plugin language files only when needed (if plugin enabled and user in administrator client)

* Update stats.php

* remove autoloadLanguage property and use this

roland-d added a commit to roland-d/joomla-cms that referenced this pull request


          Merge remote-tracking branch 'origin/shareable-draft-content' into sh…

0ff1886

…areable-draft-content

* origin/shareable-draft-content: (245 commits)
  Implement shareable draft links
  Cleaned up shared drafts view Added front-end token generarion
  Implement shared drafts view
  Remove obsolete file
  use only root (joomla#11703)
  com_search category results not displaying date (joomla#11802)
  warnings and errors, not notices ... (joomla#11801)
  [installation] Add javascript message titles and ajax errors strings (joomla#11800)
  Regression: Normalising head links and correcting hreflang for menu items associations (joomla#11769)
  Refactor allowEdit of backend category controller (joomla#11547)
  [com_contact] Move event trigger to correct place (joomla#11719)
  Improve the accessibility of the top menu in ISIS part 2 (joomla#11729)
  Show file extension (joomla#11776)
  change button -> a for the modal close button (joomla#11787)
  Small Grammar change (joomla#11788)
  Change message type to error when download of update package fails (joomla#11791)
  these are warnings not messages ... (joomla#11799)
  [plg_content_vote|pagebreak] Load language files only when needed (joomla#11730)
  [plg_system_stats] Load plugin language files only when needed (joomla#11728)
  Fix creation performance of form element menuparent, (slow down in menu item edit form, for item that belongs to large menu) (joomla#11628)
  ...

# Conflicts:
#	administrator/components/com_admin/script.php
#	administrator/components/com_content/models/shared.php
#	administrator/components/com_content/views/shared/tmpl/default.php
#	administrator/language/en-GB/en-GB.xml
#	administrator/language/en-GB/install.xml
#	administrator/manifests/files/joomla.xml
#	administrator/manifests/packages/pkg_en-GB.xml
#	installation/language/en-GB/en-GB.xml
#	language/en-GB/en-GB.xml
#	language/en-GB/install.xml
#	libraries/cms/pagination/pagination.php
#	libraries/cms/version/version.php
#	libraries/joomla/authentication/authentication.php
#	libraries/joomla/form/fields/color.php
#	libraries/joomla/form/fields/email.php
#	media/system/js/share-uncompressed.js
#	media/system/js/share.js
#	plugins/content/vote/vote.php

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet