Refactor allowEdit of backend category controller

[ggppdk]

Make category controller similar to PRs

#11503
#11502
#11511

Testing instructions

Test that edit and edit own in backend category manager work properly

[ggppdk]

@wilsonge

please do not forget of this one, it is related to the other PRs

[andrepereiradasilva]

ok so i just found on ething that seems an issue, or at leaset and inconsistency

• use a user with "Administrator" group
• create with that user this two categories

• Create another category with super user so it stays like this

• At com_content set Edit as Denied for the "Administrator" group
• At "Test ACL" level don't change permission
• At "Test ACL Sub" level set "Edit Own to "Denied"
• At "Test ACL Sub (Super User)" level don't change permission
• Now use the test user and you will get something like this
  

All ok.

• Now try to access /administrator/index.php?option=com_categories&task=category.edit&id=12&extension=com_content (replace 12 for the id of the "Test ACL Sub (Super User)" category). You get
  
• Now try to access /administrator/index.php?option=com_categories&task=category.edit&id=11&extension=com_content (replace 11 for the id of the "Test ACL Sub" category). Here, instead of getting the "Edit not allowed" error (as all the other cases) you go to the "Edit" layout, but without save buttons
  

This happens with and without your patch.
Can you check if this is the supposed behaviour?

[ggppdk]

Good catch, thanks

i replicated it , for an (administrator) user that owns the record (category),
and "edit own" was denied for administrator usergroup

In my local testing copy,
i did not have that check included (so it was working properly in my tests ...),

and when editing the file via Github UI, i failed to remove it from the old code

please retest

[andrepereiradasilva]

I have tested this item ✅ successfully on 0767861

Seems to work fine now.

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11547.}

[dgrammatiko]

I have tested this item ✅ successfully on 0767861

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11547.}

[dgrammatiko]

RTC