Increase default flamegraph fidelity #204
Conversation
See also jonhoo#153. PR jonhoo#136 changed the semantics of the `--minwidth` option from output pixel width to percentage width (which is effectively the same as pct of total samples), which greatly reduced the default fidelity of flamegraphs as 0.1% of total time is quite coarse, especially once you start zooming in. This PR reduces the default to 0.01%, which produces pretty much identical output as flamegraph.pl / old inferno at ~1200px wide and includes a much greater number of bars. I think this change is worth making as it makes it reduces friction for people migrating from flamegraph.pl, and in my tests produces much more useful output by default. I've also updated the description of the option to match the current behaviour, as it still mentioned pixels and that had me confused for a good while.
|
I do miss the rounded corners, I think they helped pick out the edges of samples quite a bit. |
|
Looks like a bunch of the test output files would need updating due to this -- I'll do that if you're happy taking this change, else just pare this down to the description fix. |
|
I quite like the change! Rounded corners shouldn't be too hard to add back in with CSS if you want them. I think |
Codecov Report
@@ Coverage Diff @@
## master #204 +/- ##
=======================================
Coverage 90.08% 90.08%
=======================================
Files 17 17
Lines 2239 2239
=======================================
Hits 2017 2017
Misses 222 222
Continue to review full report at Codecov.
|
See also #153. PR #136 changed the semantics of the
--minwidthoption from output pixel width to percentage width (which is effectively the same as pct of total samples), which greatly reduced the default fidelity of flamegraphs as 0.1% of total time is quite coarse, especially once you start zooming in.This PR reduces the default to 0.01%, which produces pretty much identical output as flamegraph.pl / old inferno at ~1200px wide and includes a much greater number of bars. I think this change is worth making as it makes it reduces friction for people migrating from flamegraph.pl, and in my tests produces much more useful output by default.
I've also updated the description of the option to match the current behaviour, as it still mentioned pixels and that had me confused for a good while.