Add support for "fluid" drawing #136
Conversation
Codecov Report
@@ Coverage Diff @@
## master #136 +/- ##
=======================================
Coverage 89.82% 89.82%
=======================================
Files 10 10
Lines 1150 1150
=======================================
Hits 1033 1033
Misses 117 117Continue to review full report at Codecov.
|
|
It seems to work well in Firefox and Chrome, but I tested in Safari and Edge, and they both had weird behaviors that I need to look into. |
|
OK, I've got it working well in Safari and Edge now. |
See also jonhoo#153. PR jonhoo#136 changed the semantics of the `--minwidth` option from output pixel width to percentage width (which is effectively the same as pct of total samples), which greatly reduced the default fidelity of flamegraphs as 0.1% of total time is quite coarse, especially once you start zooming in. This PR reduces the default to 0.01%, which produces pretty much identical output as flamegraph.pl / old inferno at ~1200px wide and includes a much greater number of bars. I think this change is worth making as it makes it reduces friction for people migrating from flamegraph.pl, and in my tests produces much more useful output by default. I've also updated the description of the option to match the current behaviour, as it still mentioned pixels and that had me confused for a good while.
|
While it's a great change, this is really expensive to render for complex flamegraphs. Compare initial load and render times:
Zoom is also a bit slower:
With 40-60% of the time spent in |
|
#262 does the trick with a monospace font. |
|
@bobrik Yeah, there's definitely a cost involved with having the browser do this work. I think there's a decent argument for us just making monospace fonts the default — what do you think? |
|
That sounds reasonable to me. We should probably allow passing multiple font families at the same time too, so that users can have a preference list rather than one choice that might not be available on every platform. |
Closes #135