PR: Add support for coma separated text files for weather datafiles #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Created a new function to open weather datafile that can determine if the file is tab or coma separated.
jnsebgosselin
changed the title
This function will act as a bottleneck where everything that needs to save content to csv will have to go through. This way, if we need to change anything about the csv format in the future, this will be easy to do it application wide.
Merged
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #76
As stated in Issue #76, the objective of this PR is to save and read weather data input and output files using a coma separated text value format. Currently, a tab-separated format is used. This is confusing and harder to manipulate text files with other separators in Windows. Besides, csv stand for "Coma Separated Value", so...
This has been asked and noted by numerous people, so this is a much needed change, but it has a lot of ramifications in the code and more particularly in old code, where not everything is pretty 😱. Besides, support for tab-separated value text file should be kept also.