PR: Add tests for gapfill_weather_gui.py, gapfill_weather_algorithm2.py, and manager_data.py #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While writing the test, I also corrected an error in the gapfill_weather_gui that prevented the test to run correctly.
jnsebgosselin
changed the title
This reverts commit 9a65250.
File ordering is not the same in Windows and Linux, that is why this was not working on Travis.
jnsebgosselin
changed the title
jnsebgosselin
changed the title
Added a function to the utils module to delete a folder recursively
The module "weather_station_browser.py" is deprecated and was replaced by the module named "weather_station_finder.py"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These modules were almost not covered by the test suite and are crucial for GWHAT to run properly. Writing tests for these modules has become important for preventing bugs to creep in the code when doing modifications.
Indeed, this PR allowed to fixed some bugs that were introduced in the recent changes:
.errfiles were not loaded correctly (introduced in PR PR: Add support for coma separated text files for weather datafiles #84).Also:
utilsmodule to delete the content of a folder recursively.