[kibana] add service.httpPortName config in chart (elastic#843)

Co-authored-by: Julien Mailleret <8582351+jmlrt@users.noreply.github.com>
jmlrt · Dec 1, 2020 · 4ad3e8a · 4ad3e8a
1 parent 7c69a50
commit 4ad3e8a
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 1 deletion.
diff --git a/kibana/templates/service.yaml b/kibana/templates/service.yaml
@@ -26,7 +26,7 @@ spec:
       nodePort: {{ .Values.service.nodePort }}
 {{- end }}
       protocol: TCP
-      name: http
+      name: {{ .Values.service.httpPortName | default "http" }}
       targetPort: {{ .Values.httpPort }}
   selector:
     app: {{ .Chart.Name }}

diff --git a/kibana/tests/kibana_test.py b/kibana/tests/kibana_test.py
@@ -629,3 +629,16 @@ def test_adding_loadBalancerIP():
     r = helm_template(config)
 
     assert r["service"][name]["spec"]["loadBalancerIP"] == "12.5.11.79"
+
+
+def test_service_port_name():
+    r = helm_template("")
+
+    config = """
+    service:
+      httpPortName: istio
+    """
+
+    r = helm_template(config)
+
+    assert r["service"][name]["spec"]["ports"][0]["name"] == "istio"
diff --git a/kibana/values.yaml b/kibana/values.yaml
@@ -107,6 +107,7 @@ service:
     # service.beta.kubernetes.io/cce-load-balancer-internal-vpc: "true"
   loadBalancerSourceRanges: []
     # 0.0.0.0/0
+  httpPortName: http
 
 ingress:
   enabled: false