This repository has been archived by the owner on May 16, 2023. It is now read-only.
[kibana] add service.httpPortName config in chart #843
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
jmlrt
suggested changes
Nov 4, 2020
kibana/tests/kibana_test.py
Outdated
| def test_service_port_name(): | ||
| r = helm_template("") | ||
|
|
||
| assert r["service"][name]["spec"]["ports"][0]["name"] == "http" |
There was a problem hiding this comment.
Can you move this assertion to https://github.com/elastic/helm-charts/blob/master/kibana/tests/kibana_test.py#L12?
| @@ -629,3 +629,17 @@ def test_adding_loadBalancerIP(): | |||
| r = helm_template(config) | |||
|
|
|||
| assert r["service"][name]["spec"]["loadBalancerIP"] == "12.5.11.79" | |||
|
|
|||
There was a problem hiding this comment.
Black formatter requires 2 empty lines between each function.
Can you run black kibana/tests/kibana_test.py to fix it?
This assertion is already tested in `test_defaults` https://github.com/ebuildy/helm-charts/blob/dadda2a8b1aa714cc38064064091522c73f3691d/kibana/tests/kibana_test.py#L23
|
jenkins test this please |
|
I updated the python test to be able to merge the PR. Thanks for your work @ebuildy 👍 |
jmlrt
added a commit
to jmlrt/helm-charts
that referenced
this pull request
Dec 1, 2020
Co-authored-by: Julien Mailleret <8582351+jmlrt@users.noreply.github.com>
jmlrt
added a commit
to jmlrt/helm-charts
that referenced
this pull request
Dec 1, 2020
Co-authored-by: Julien Mailleret <8582351+jmlrt@users.noreply.github.com>
jmlrt
added a commit
to jmlrt/helm-charts
that referenced
this pull request
Dec 1, 2020
Co-authored-by: Julien Mailleret <8582351+jmlrt@users.noreply.github.com>
jmlrt
added a commit
that referenced
this pull request
Dec 1, 2020
jmlrt
added a commit
that referenced
this pull request
Dec 1, 2020
jmlrt
added a commit
that referenced
this pull request
Dec 1, 2020
Closed
This was referenced Feb 12, 2021
Merged
Closed
Closed
Closed
This was referenced Dec 14, 2021
Merged
Merged
Merged
This was referenced Sep 14, 2022
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
${CHART}/tests/*.py${CHART}/examples/*/test/goss.yamlFix #841: "Kibana: Missing service.httpPortName config in chart"