Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BibTeX Sniffer: stack runaway (nonresponsive & crash) when lib has all docs auto-filled with BibTeX and Wizard is ON #60

Closed
GerHobbelt opened this issue Aug 26, 2019 · 1 comment
Closed

BibTeX Sniffer: stack runaway (nonresponsive & crash) when lib has all docs auto-filled with BibTeX and Wizard is ON #60

GerHobbelt opened this issue Aug 26, 2019 · 1 comment
Labels
🐛bug Something isn't working
Milestone
v82

Comments

@GerHobbelt
Copy link
Collaborator

Another kind of stack runaway similar to #59, but nastier:

when the library has a set of auto-filled BibTeX documents and the filter radio-buttons is set to AUTO and the AutoWizard is turned ON (the magic hat at right in Sniffer window), then the result is another Qiqqa runaway.

...
 	Qiqqa.exe!Qiqqa.Documents.PDF.PDFControls.MetadataControls.GoogleBibTexSnifferControl.ReflectPDFDocument(string search_terms) Line 629	C#
 	Qiqqa.exe!Qiqqa.Documents.PDF.PDFControls.MetadataControls.GoogleBibTexSnifferControl.MoveDelta(int direction) Line 359	C#
 	Qiqqa.exe!Qiqqa.Documents.PDF.PDFControls.MetadataControls.GoogleBibTexSnifferControl.TxtBibTeX_TextChanged(object sender, System.Windows.Controls.TextChangedEventArgs e) Line 289	C#
 	[External Code]	
 	Qiqqa.exe!Qiqqa.Documents.PDF.PDFControls.MetadataControls.GoogleBibTexSnifferControl.ReflectPDFDocument(string search_terms) Line 638	C#
 	Qiqqa.exe!Qiqqa.Documents.PDF.PDFControls.MetadataControls.GoogleBibTexSnifferControl.MoveDelta(int direction) Line 359	C#
 	Qiqqa.exe!Qiqqa.Documents.PDF.PDFControls.MetadataControls.GoogleBibTexSnifferControl.TxtBibTeX_TextChanged(object sender, System.Windows.Controls.TextChangedEventArgs e) Line 289	C#
 	[External Code]	
 	Qiqqa.exe!Qiqqa.Documents.PDF.PDFControls.MetadataControls.GoogleBibTexSnifferControl.ReflectPDFDocument(string search_terms) Line 629	C#
 	Qiqqa.exe!Qiqqa.Documents.PDF.PDFControls.MetadataControls.GoogleBibTexSnifferControl.MoveDelta(int direction) Line 359	C#
 	Qiqqa.exe!Qiqqa.Documents.PDF.PDFControls.MetadataControls.GoogleBibTexSnifferControl.TxtBibTeX_TextChanged(object sender, System.Windows.Controls.TextChangedEventArgs e) Line 289	C#
 	[External Code]	
 	Qiqqa.exe!Qiqqa.Documents.PDF.PDFControls.MetadataControls.GoogleBibTexSnifferControl.ReflectPDFDocument(string search_terms) Line 638	C#
 	Qiqqa.exe!Qiqqa.Documents.PDF.PDFControls.MetadataControls.GoogleBibTexSnifferControl.MoveDelta(int direction) Line 359	C#
 	Qiqqa.exe!Qiqqa.Documents.PDF.PDFControls.MetadataControls.GoogleBibTexSnifferControl.TxtBibTeX_TextChanged(object sender, System.Windows.Controls.TextChangedEventArgs e) Line 289	C#
 	[External Code]	
 	Qiqqa.exe!Qiqqa.Documents.PDF.PDFControls.MetadataControls.GoogleBibTexSnifferControl.ReflectPDFDocument(string search_terms) Line 629	C#
 	Qiqqa.exe!Qiqqa.Documents.PDF.PDFControls.MetadataControls.GoogleBibTexSnifferControl.MoveDelta(int direction) Line 359	C#
 	Qiqqa.exe!Qiqqa.Documents.PDF.PDFControls.MetadataControls.GoogleBibTexSnifferControl.TxtBibTeX_TextChanged(object sender, System.Windows.Controls.TextChangedEventArgs e) Line 289	C#
 	[External Code]	
 	Qiqqa.exe!Qiqqa.Documents.PDF.PDFControls.MetadataControls.GoogleBibTexSnifferControl.ReflectPDFDocument(string search_terms) Line 638	C#
 	Qiqqa.exe!Qiqqa.Documents.PDF.PDFControls.MetadataControls.GoogleBibTexSnifferControl.MoveDelta(int direction) Line 359	C#
 	Qiqqa.exe!Qiqqa.Documents.PDF.PDFControls.MetadataControls.GoogleBibTexSnifferControl.TxtBibTeX_TextChanged(object sender, System.Windows.Controls.TextChangedEventArgs e) Line 289	C#
 	[External Code]	
 	Qiqqa.exe!Qiqqa.Documents.PDF.PDFControls.MetadataControls.GoogleBibTexSnifferControl.ReflectPDFDocument(string search_terms) Line 629	C#
 	Qiqqa.exe!Qiqqa.Documents.PDF.PDFControls.MetadataControls.GoogleBibTexSnifferControl.MoveDelta(int direction) Line 359	C#
 	Qiqqa.exe!Qiqqa.Documents.PDF.PDFControls.MetadataControls.GoogleBibTexSnifferControl.TxtBibTeX_TextChanged(object sender, System.Windows.Controls.TextChangedEventArgs e) Line 289	C#
 	[External Code]	
 	The maximum number of stack frames supported by Visual Studio has been exceeded.
@GerHobbelt GerHobbelt mentioned this issue Aug 26, 2019
Closed
GerHobbelt added a commit to GerHobbelt/qiqqa-open-source that referenced this issue Aug 26, 2019
@GerHobbelt
fix: jimmejardine#60 + jimmejardine#39 + better fix for jimmejardine#59
6148b13 
check how many PDF files actually match and only move forward when we don't end up full circle. don't reflect if we didn't change. when we re-render the same document, we don't move at all!
@GerHobbelt GerHobbelt changed the title BibTeX Sniffer: stack runaway (nonresponsive & crash) when lib has all docs auto-filled with BibTeX and Wizard is ON ✅BibTeX Sniffer: stack runaway (nonresponsive & crash) when lib has all docs auto-filled with BibTeX and Wizard is ON Aug 26, 2019
@GerHobbelt
Copy link
Collaborator Author

Closing and decluttering the issue list so it stays workable for me: fixed in https://github.com/GerHobbelt/qiqqa-open-source mainline=master branch, pending #15 / any maintainer rights/actions.

@GerHobbelt GerHobbelt mentioned this issue Sep 3, 2019
Closed
GerHobbelt added a commit to GerHobbelt/qiqqa-open-source that referenced this issue Oct 2, 2019
@GerHobbelt
fix: jimmejardine#60 + jimmejardine#39 + better fix for jimmejardine#59
aaeae9b 
check how many PDF files actually match and only move forward when we don't end up full circle. don't reflect if we didn't change. when we re-render the same document, we don't move at all!
GerHobbelt added a commit to GerHobbelt/qiqqa-open-source that referenced this issue Oct 3, 2019
@GerHobbelt
fix: jimmejardine#60 + jimmejardine#39 + better fix for jimmejardine#59
9b75914 
check how many PDF files actually match and only move forward when we don't end up full circle. don't reflect if we didn't change. when we re-render the same document, we don't move at all!
@GerHobbelt GerHobbelt changed the title ✅BibTeX Sniffer: stack runaway (nonresponsive & crash) when lib has all docs auto-filled with BibTeX and Wizard is ON BibTeX Sniffer: stack runaway (nonresponsive & crash) when lib has all docs auto-filled with BibTeX and Wizard is ON Oct 4, 2019
@GerHobbelt GerHobbelt added the 🐛bug Something isn't working label Oct 4, 2019
@GerHobbelt GerHobbelt added this to the v82 milestone Oct 4, 2019
GerHobbelt added a commit that referenced this issue Nov 5, 2019
@GerHobbelt
fix: #60 + #39 + better fix for #59
be0d54f 
check how many PDF files actually match and only move forward when we don't end up full circle. don't reflect if we didn't change. when we re-render the same document, we don't move at all!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🐛bug Something isn't working
Projects
None yet
Milestone
v82
Development

No branches or pull requests
1 participant
@GerHobbelt