Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sniffer: when Wizard is ON, this blocks all editing of the BibTex and overwrites existing BibTeX #39

Closed
GerHobbelt opened this issue Aug 8, 2019 · 2 comments
Closed

Sniffer: when Wizard is ON, this blocks all editing of the BibTex and overwrites existing BibTeX #39

GerHobbelt opened this issue Aug 8, 2019 · 2 comments
Labels
🐛bug Something isn't working
Milestone
v82

Comments

@GerHobbelt
Copy link
Collaborator

HTR:

  • pick a PDF with bibtex where Google Scholar will find a BibTex record too.

  • if the Sniffer DOES NOT have Wizard turn on yet:

    • open the Sniffer.
    • Turn on (enable) the Wizard
    • exit/close Sniffer

  • open the Sniffer

  • Google Scholar will dig up the BibTex, Qiqqa Sniffer will snarfle that BibTex and dump it in the top-right corner box, turning it green.

  • ... no try to edit something in there...

The moment you change something, the Google Scholar snarfle -> Wizard action will quickly jitter the screen a bit and your edit will be ERASED.

Same process can be used to nuke existing BibTeX. Which IS SUPPOSED to be correct.

Hence: Wizard action should NEVER overwrite existing BibTeX!
@GerHobbelt
Copy link
Collaborator Author

Suspicion: related to #59? Related to #60? 🤔

GerHobbelt added a commit to GerHobbelt/qiqqa-open-source that referenced this issue Aug 26, 2019
@GerHobbelt
fix: jimmejardine#60 + jimmejardine#39 + better fix for jimmejardine#59
6148b13 
check how many PDF files actually match and only move forward when we don't end up full circle. don't reflect if we didn't change. when we re-render the same document, we don't move at all!
@GerHobbelt GerHobbelt changed the title Sniffer: when Wizard is ON, this blocks all editing of the BibTex and overwrites existing BibTeX ✅Sniffer: when Wizard is ON, this blocks all editing of the BibTex and overwrites existing BibTeX Aug 26, 2019
@GerHobbelt
Copy link
Collaborator Author

Closing and decluttering the issue list so it stays workable for me: fixed in https://github.com/GerHobbelt/qiqqa-open-source mainline=master branch, pending #15 / any maintainer rights/actions.

GerHobbelt added a commit to GerHobbelt/qiqqa-open-source that referenced this issue Oct 2, 2019
@GerHobbelt
fix: jimmejardine#60 + jimmejardine#39 + better fix for jimmejardine#59
aaeae9b 
check how many PDF files actually match and only move forward when we don't end up full circle. don't reflect if we didn't change. when we re-render the same document, we don't move at all!
GerHobbelt added a commit to GerHobbelt/qiqqa-open-source that referenced this issue Oct 3, 2019
@GerHobbelt
fix: jimmejardine#60 + jimmejardine#39 + better fix for jimmejardine#59
9b75914 
check how many PDF files actually match and only move forward when we don't end up full circle. don't reflect if we didn't change. when we re-render the same document, we don't move at all!
@GerHobbelt GerHobbelt changed the title ✅Sniffer: when Wizard is ON, this blocks all editing of the BibTex and overwrites existing BibTeX Sniffer: when Wizard is ON, this blocks all editing of the BibTex and overwrites existing BibTeX Oct 4, 2019
@GerHobbelt GerHobbelt added the 🐛bug Something isn't working label Oct 4, 2019
@GerHobbelt GerHobbelt added this to the v82 milestone Oct 4, 2019
GerHobbelt added a commit that referenced this issue Nov 5, 2019
@GerHobbelt
fix: #60 + #39 + better fix for #59
be0d54f 
check how many PDF files actually match and only move forward when we don't end up full circle. don't reflect if we didn't change. when we re-render the same document, we don't move at all!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🐛bug Something isn't working
Projects
None yet
Milestone
v82
Development

No branches or pull requests
1 participant
@GerHobbelt