Use Yarn PnP

[SimenB]

Summary

#10188 landed yarn v2 with node-modules linker. I wanna play with PnP - even if we don't land it for whatever reason, any errors raised by it is likely things we should fix on master.

Test plan

Green CI at some point.

[nicolo-ribaudo]

As a workaround for babel/babel#11118, you can use packageExtensions.

[SimenB]

thanks @nicolo-ribaudo, did that and also (tried to) fix all the other errors we get from the tsc build.

[SimenB]

Landed a bit of this in #9545, all the things yarn install complained about and the ones I noticed when running tests. Still a bunch of failures, will need to look more later again

[SimenB]

Can remove the packageExtensions as yarn does it automatically: https://github.com/yarnpkg/berry/pull/1847/files

[SimenB]

@merceyz hey, happy new year! 😀 Would you be able to take a look at the error with lint and typescript?

• https://github.com/facebook/jest/actions/runs/3818199835/jobs/6494956216
  • there's a weird require: https://github.com/taskworld/eslint-plugin-local/blob/master/index.js#L1
  • trying to load https://github.com/facebook/jest/tree/main/.eslintplugin
• https://github.com/facebook/jest/actions/runs/3818199835/jobs/6494956501
  • WebAssembly is not defined, but AFAICT it should be part of TS proper?
• Also seeing an error loading the test env, but I haven't dug into that one yet

[merceyz]

Hey, happy (late) new year! 😄

there's a weird require

It's something alright, fixed in #13836.

WebAssembly is not defined, but AFAICT it should be part of TS proper?

It's in the DOM types so you need to either add /// <reference lib="dom" /> to the file or DOM to the tsconfig.json compilerOptions.lib option.
The reason it works with node_modules is most likely because @types/jsdom is hoisted to the root and contains /// <reference lib="dom" />.

Also seeing an error loading the test env, but I haven't dug into that one yet

Some of the examples aren't declaring jest-environment-jsdom as a dependency.

diff --git a/examples/angular/package.json b/examples/angular/package.json
index cb64e7476e..5c9fa12e7b 100644
--- a/examples/angular/package.json
+++ b/examples/angular/package.json
@@ -27,6 +27,7 @@
     "babel-jest": "workspace:^",
     "babel-plugin-transform-typescript-metadata": "*",
     "jest": "workspace:^",
+    "jest-environment-jsdom": "workspace:^",
     "jest-zone-patch": "*"
   }
 }
diff --git a/examples/jquery/package.json b/examples/jquery/package.json
index c7808e236c..7952a710b6 100644
--- a/examples/jquery/package.json
+++ b/examples/jquery/package.json
@@ -6,7 +6,8 @@
     "@babel/core": "^7.11.6",
     "@babel/preset-env": "^7.1.0",
     "babel-jest": "workspace:^",
-    "jest": "workspace:^"
+    "jest": "workspace:^",
+    "jest-environment-jsdom": "workspace:^"
   },
   "dependencies": {
     "jquery": "^3.2.1"
diff --git a/examples/react-testing-library/package.json b/examples/react-testing-library/package.json
index 9caf65477a..478ed69447 100644
--- a/examples/react-testing-library/package.json
+++ b/examples/react-testing-library/package.json
@@ -12,7 +12,8 @@
     "@babel/preset-react": "^7.12.1",
     "@testing-library/react": "^12.1.5",
     "babel-jest": "workspace:^",
-    "jest": "workspace:^"
+    "jest": "workspace:^",
+    "jest-environment-jsdom": "workspace:^"
   },
   "scripts": {
     "test": "jest"
diff --git a/examples/react/package.json b/examples/react/package.json
index f100ce09fc..a1c2e80e72 100644
--- a/examples/react/package.json
+++ b/examples/react/package.json
@@ -11,7 +11,8 @@
     "@babel/preset-env": "^7.1.0",
     "@babel/preset-react": "^7.12.1",
     "babel-jest": "workspace:^",
-    "jest": "workspace:^"
+    "jest": "workspace:^",
+    "jest-environment-jsdom": "workspace:^"
   },
   "scripts": {
     "test": "jest"
diff --git a/examples/typescript/package.json b/examples/typescript/package.json
index 3ca4c4463c..22cf5abfa7 100644
--- a/examples/typescript/package.json
+++ b/examples/typescript/package.json
@@ -14,7 +14,8 @@
     "@babel/preset-typescript": "^7.0.0",
     "@jest/globals": "workspace:^",
     "babel-jest": "workspace:^",
-    "jest": "workspace:^"
+    "jest": "workspace:^",
+    "jest-environment-jsdom": "workspace:^"
   },
   "scripts": {
     "test": "jest"

[SimenB]

Thanks for taking a look!

---

The WebAssembly issue seems to be an old one: microsoft/TypeScript-DOM-lib-generator#826

[github-actions]

This PR is stale because it has been open 1 year with no activity. Remove stale label or comment or this will be closed in 30 days.

[github-actions]

This PR was closed because it has been stalled for 30 days with no activity. Please open a new PR if the issue is still relevant, linking to this one.