Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix stack-trace when calling done with non-error #6016

Merged
merged 2 commits into from
Apr 18, 2018
Merged

fix stack-trace when calling done with non-error #6016

merged 2 commits into from
Apr 18, 2018

Conversation

SimenB
Copy link
Member

@SimenB SimenB commented Apr 17, 2018 •
edited
Loading

Summary

See https://github.com/facebook/jest/pull/6008/files#r182010622.

No changelog as it's a bug fix for a PR merged to master today.

Test plan

Green CI

@SimenB SimenB mentioned this pull request Apr 17, 2018
Merged
SimenB
SimenB commented Apr 17, 2018
View reviewed changes
packages/jest-jasmine2/src/jasmine/Env.js Outdated
@@ -561,6 +561,7 @@ export default function(j$) {
expected: '',
actual: '',
message,
fromFail: true,
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not really happy with this one... Thoughts?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wait, got a better one, pushing

@SimenB SimenB changed the title fix stack-trace when calling done fix stack-trace when calling done with non-error Apr 17, 2018
@codecov-io
Copy link

codecov-io commented Apr 17, 2018 •
edited
Loading

Codecov Report

Merging #6016 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #6016   +/-   ##
======================================
  Coverage    64.3%   64.3%           
======================================
  Files         217     217           
  Lines        8317    8317           
  Branches        3       3           
======================================
  Hits         5348    5348           
  Misses       2968    2968           
  Partials        1       1
Impacted Files Coverage Δ
packages/jest-jasmine2/src/jasmine/Env.js 0% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 02e1c66...ebcf9f0. Read the comment docs.

@cpojer cpojer merged commit a36a69c into jestjs:master Apr 18, 2018
@cpojer
Copy link
Member

cpojer commented Apr 18, 2018

Thanks for fixing this.

@SimenB SimenB deleted the done-stack branch April 18, 2018 07:32
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@thymikee thymikee thymikee approved these changes

@rickhanlonii rickhanlonii Awaiting requested review from rickhanlonii

Assignees
No one assigned
Labels
cla signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@SimenB @codecov-io @cpojer @thymikee @facebook-github-bot